Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mcol 5776 support functions not in group by #3257

Open
wants to merge 161 commits into
base: develop
Choose a base branch
from

Conversation

mariadb-SergeyZefirov
Copy link
Contributor

An attempt to make our support of SELECT GROUP BY to be closer to server's.

@mariadb-SergeyZefirov mariadb-SergeyZefirov force-pushed the MCOL-5776-support-functions-not-in-GROUP-BY branch 2 times, most recently from 90bd0e4 to 4cd6105 Compare August 8, 2024 07:27
@mariadb-SergeyZefirov mariadb-SergeyZefirov force-pushed the MCOL-5776-support-functions-not-in-GROUP-BY branch 4 times, most recently from 6811b55 to ccc0c5d Compare August 30, 2024 09:03
@mariadb-SergeyZefirov
Copy link
Contributor Author

What does this patch do:

  • it prevents wrapping into aggregates values under GROUP BY keys, changes in ha_mcs_execplan.cpp are related to that;
  • it also disabled lowering of HAVING filter into WHERE if there are no aggregates (joblistfactory.cpp).

Other changes are related to build troubles (CMakefile.txt) and not much else.

There will be a separate PR for regression suite.

Right now it is still draft and is not rebased for me to have history of changes.

@mariadb-SergeyZefirov mariadb-SergeyZefirov marked this pull request as ready for review September 12, 2024 09:53
@mariadb-SergeyZefirov mariadb-SergeyZefirov force-pushed the MCOL-5776-support-functions-not-in-GROUP-BY branch from a6a9e0b to 580ce10 Compare September 17, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant