NodeJS 12 #47
Open
NodeJS 12 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcominetti , can we make progress towards merging this? |
|
@marcominetti tested |
atsjj
added a commit
to atsjj/memwatch
that referenced
this pull request
May 7, 2020
* Forked from https://github.com/marcominetti/node-memwatch * Merged pull request marcominetti#47 * Refactored from Mocha to Ava, renamed `tests.js` to `test.js` * Added `ava` at `^3.8.1` * Bumped `bindings` to `^1.5.0` * Bumped `nan` to `^2.14.1` * Bumped required node version to `>= 12` * Removed `mocha` * Removed `should` * Cleaned up package.json, consolidated `contributors` * Added `auto-changelog` config to package.json * Added `release-it` config to package.json * Added missing contributors to package.json * Changed package name to `@atsjj/memwatch-next`
|
I've gone ahead and merged this request on my own fork and published to NPM @pavel-yasiukevich, please see https://github.com/atsjj/memwatch/releases/tag/1.0.0. I needed this patch and figured others would benefit from it too! Much appreciation to those who have contributed, I feel this is the least I could do to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added v8::Isolate and v8::Context as method parameters since deprecated API was removed.
I also got the rid of legacy v8::Handle replacing it with v8::Local.
Tested both on Ubuntu and Windows for the following major NodeJS versions: 8, 10, 12.