Skip to content

Commit

Permalink
Fixes #71
Browse files Browse the repository at this point in the history
  • Loading branch information
Márcio Almada committed Jul 20, 2021
1 parent be17263 commit 1e82d5a
Showing 0 changed files with 0 additions and 0 deletions.

3 comments on commit 1e82d5a

@marcioAlmada
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@e1himself history was rewritten from that point forwards without the issue

@e1himself
Copy link

@e1himself e1himself commented on 1e82d5a Jul 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

However, please note that overwriting history in a public repo with lots of forks and a couple of PRs will cause problems to all the other repos. People will have conflicts merging changes from the upstream.

As of me, I'd be fine with just removing the file from the tree with a commit. It was there for more than 2 years. So it won't cause more harm than it already could have caused :)

But that's too late, probably.

🤷‍♂️

@marcioAlmada
Copy link
Owner

@marcioAlmada marcioAlmada commented on 1e82d5a Jul 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@e1himself yeah agree but if there was potential harm I'd rather bother people with a rewritten history than keeping a suspicions file that could be built by accident. If a fork has more than 2 years it's probably better to re-fork it anyway.

Ty for noticing that, btw.

Please sign in to comment.