Fixing issue #51 (#52)

* Fixing issue #51 --------- Co-authored-by: Adrian Villa <[email protected]>
marcelblijleven · Oct 15, 2023 · 9ecb265 · 9ecb265
1 parent 29de1c4
commit 9ecb265
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/goodwe/et.py b/goodwe/et.py
@@ -34,10 +34,10 @@ class ET(Inverter):
         # ppv1 + ppv2 + ppv3 + ppv4
         Calculated("ppv",
                    lambda data:
-                   read_bytes4(data, 10) +
-                   read_bytes4(data, 18) +
-                   read_bytes4(data, 26) +
-                   read_bytes4(data, 34),
+                   max(0, read_bytes4(data, 10)) +
+                   max(0, read_bytes4(data, 18)) +
+                   max(0, read_bytes4(data, 26)) +
+                   max(0, read_bytes4(data, 34)),
                    "PV Power", "W", Kind.PV),
         Byte("pv4_mode", 38, "PV4 Mode code", "", Kind.PV),
         Enum("pv4_mode_label", 38, PV_MODES, "PV4 Mode", Kind.PV),

diff --git a/tests/test_et.py b/tests/test_et.py
@@ -393,7 +393,7 @@ def test_GW6000_EH_runtime_data(self):
         self.assertSensor('vpv2', 329.6, 'V', data)
         self.assertSensor('ipv2', 2.1, 'A', data)
         self.assertSensor('ppv2', 691, 'W', data)
-        self.assertSensor('ppv', 1546, 'W', data)
+        self.assertSensor('ppv', 1548, 'W', data)
         self.assertSensor('pv1_mode', 2, '', data)
         self.assertSensor('pv1_mode_label', 'PV panels connected, producing power', '', data)
         self.assertSensor('pv2_mode', 2, '', data)
@@ -641,7 +641,7 @@ def test_GW6000_EH_runtime_data(self):
         self.assertSensor('vpv2', 329.6, 'V', data)
         self.assertSensor('ipv2', 2.1, 'A', data)
         self.assertSensor('ppv2', 691, 'W', data)
-        self.assertSensor('ppv', 1546, 'W', data)
+        self.assertSensor('ppv', 1548, 'W', data)
         self.assertSensor('pv1_mode', 2, '', data)
         self.assertSensor('pv1_mode_label', 'PV panels connected, producing power', '', data)
         self.assertSensor('pv2_mode', 2, '', data)