Skip to content

Commit

Permalink
Add support for extended meter sensors on ETT inverters
Browse files Browse the repository at this point in the history 
Add support for extended meter sensors on  ETT inverters
  • Loading branch information
@mletenay
mletenay committed Dec 10, 2023
1 parent 6a12808 commit 16299bf
Show file tree
Hide file tree
Showing 2 changed files with 48 additions and 6 deletions.
47 changes: 44 additions & 3 deletions goodwe/et.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,17 @@ class ET(Inverter):
Apparent4("meter_apparent_power_total", 82, "Meter Apparent Power Total", Kind.GRID), # 36041/42
Integer("meter_type", 86, "Meter Type", "", Kind.GRID), # 36043 (0: Single phase, 1: 3P3W, 2: 3P4W, 3: HomeKit)
Integer("meter_sw_version", 88, "Meter Software Version", "", Kind.GRID), # 36044
# Sensors added in some ARM fw update
Power4("meter2_active_power", 90, "Meter 2 Active Power", Kind.GRID), # 36045/46
Float("meter2_e_total_exp", 94, 1000, "Meter 2 Total Energy (export)", "kWh", Kind.GRID), # 36047/48
Float("meter2_e_total_imp", 98, 1000, "Meter 2 Total Energy (import)", "kWh", Kind.GRID), # 36049/50
Integer("meter2_comm_status", 102, "Meter 2 Communication Status"), # 36051
Voltage("meter_voltage1", 104, "Meter L1 Voltage", Kind.GRID), # 36052
Voltage("meter_voltage2", 106, "Meter L2 Voltage", Kind.GRID), # 36053
Voltage("meter_voltage2", 108, "Meter L3 Voltage", Kind.GRID), # 36054
Current("meter_current1", 110, "Meter L1 Current", Kind.GRID), # 36055
Current("meter_current2", 112, "Meter L2 Current", Kind.GRID), # 36056
Current("meter_current3", 114, "Meter L3 Current", Kind.GRID), # 36057
)

# Inverter's MPPT data
Expand Down Expand Up @@ -399,11 +410,13 @@ def __init__(self, host: str, comm_addr: int = 0, timeout: int = 1, retries: int
self._READ_DEVICE_VERSION_INFO: ProtocolCommand = ModbusReadCommand(self.comm_addr, 0x88b8, 0x0021)
self._READ_RUNNING_DATA: ProtocolCommand = ModbusReadCommand(self.comm_addr, 0x891c, 0x007d)
self._READ_METER_DATA: ProtocolCommand = ModbusReadCommand(self.comm_addr, 0x8ca0, 0x2d)
self._READ_METER_DATA_EXTENDED: ProtocolCommand = ModbusReadCommand(self.comm_addr, 0x8ca0, 0x3a)
self._READ_BATTERY_INFO: ProtocolCommand = ModbusReadCommand(self.comm_addr, 0x9088, 0x0018)
self._READ_BATTERY2_INFO: ProtocolCommand = ModbusReadCommand(self.comm_addr, 0x9858, 0x0016)
self._READ_MPTT_DATA: ProtocolCommand = ModbusReadCommand(self.comm_addr, 0x89a5, 0x3d)
self._READ_MPTT_DATA: ProtocolCommand = ModbusReadCommand(self.comm_addr, 0x89e5, 0x3d)
self._has_battery: bool = True
self._has_battery2: bool = False
self._has_meter_extended: bool = False
self._has_mptt: bool = False
self._sensors = self.__all_sensors
self._sensors_battery = self.__all_sensors_battery
Expand All @@ -423,6 +436,11 @@ def _single_phase_only(s: Sensor) -> bool:
"""Filter to exclude phase2/3 sensors on single phase inverters"""
return not ((s.id_.endswith('2') or s.id_.endswith('3')) and 'pv' not in s.id_)

@staticmethod
def _not_extended_meter(s: Sensor) -> bool:
"""Filter to exclude extended meter sensors"""
return s.offset < 90

async def read_device_info(self):
response = await self._read_from_socket(self._READ_DEVICE_VERSION_INFO)
response = response[5:-2]
Expand Down Expand Up @@ -457,6 +475,9 @@ async def read_device_info(self):

if self.rated_power >= 15000:
self._has_mptt = True
self._has_meter_extended = True
else:
self._sensors_meter = tuple(filter(self._not_extended_meter, self._sensors_meter))

if self.arm_version >= 19 or self.rated_power >= 15000:
self._settings.update({s.id_: s for s in self.__settings_arm_fw_19})
Expand All @@ -476,6 +497,8 @@ async def read_runtime_data(self, include_unknown_sensors: bool = False) -> Dict
if ex.message == 'ILLEGAL DATA ADDRESS':
logger.warning("Cannot read battery values, disabling further attempts.")
self._has_battery = False
else:
raise ex
if self._has_battery2:
try:
raw_data = await self._read_from_socket(self._READ_BATTERY2_INFO)
Expand All @@ -484,9 +507,25 @@ async def read_runtime_data(self, include_unknown_sensors: bool = False) -> Dict
if ex.message == 'ILLEGAL DATA ADDRESS':
logger.warning("Cannot read battery 2 values, disabling further attempts.")
self._has_battery2 = False
else:
raise ex

raw_data = await self._read_from_socket(self._READ_METER_DATA)
data.update(self._map_response(raw_data[5:-2], self._sensors_meter, include_unknown_sensors))
if self._has_meter_extended:
try:
raw_data = await self._read_from_socket(self._READ_METER_DATA_EXTENDED)
data.update(self._map_response(raw_data[5:-2], self._sensors_meter, include_unknown_sensors))
except RequestRejectedException as ex:
if ex.message == 'ILLEGAL DATA ADDRESS':
logger.warning("Cannot read extended meter values, disabling further attempts.")
self._has_meter_extended = False
self._sensors_meter = tuple(filter(self._not_extended_meter, self._sensors_meter))
raw_data = await self._read_from_socket(self._READ_METER_DATA)
data.update(self._map_response(raw_data[5:-2], self._sensors_meter, include_unknown_sensors))
else:
raise ex
else:
raw_data = await self._read_from_socket(self._READ_METER_DATA)
data.update(self._map_response(raw_data[5:-2], self._sensors_meter, include_unknown_sensors))

if self._has_mptt:
try:
Expand All @@ -496,6 +535,8 @@ async def read_runtime_data(self, include_unknown_sensors: bool = False) -> Dict
if ex.message == 'ILLEGAL DATA ADDRESS':
logger.warning("Cannot read MPPT values, disabling further attempts.")
self._has_mptt = False
else:
raise ex

return data

Expand Down
7 changes: 4 additions & 3 deletions tests/test_et.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from unittest import TestCase

from goodwe.et import ET
from goodwe.exceptions import RequestFailedException
from goodwe.exceptions import RequestRejectedException
from goodwe.inverter import OperationMode
from goodwe.protocol import ProtocolCommand

Expand All @@ -29,7 +29,7 @@ async def _read_from_socket(self, command: ProtocolCommand) -> bytes:
with open(root_dir + '/sample/et/' + filename, 'r') as f:
response = bytes.fromhex(f.read())
if not command.validator(response):
raise RequestFailedException
raise RequestRejectedException('ILLEGAL DATA ADDRESS')
return response
else:
self.request = command.request
Expand Down Expand Up @@ -889,6 +889,7 @@ def __init__(self, methodName='runTest'):
self.mock_response(self._READ_DEVICE_VERSION_INFO, 'GW25K-ET_device_info.hex')
self.mock_response(self._READ_RUNNING_DATA, 'GW25K-ET_running_data.hex')
self.mock_response(self._READ_METER_DATA, 'GW25K-ET_meter_data.hex')
self.mock_response(self._READ_METER_DATA_EXTENDED, 'GW25K-ET_meter_data.hex')
self.mock_response(self._READ_BATTERY_INFO, 'GW25K-ET_battery_info.hex')
# self.mock_response(self._READ_BATTERY_INFO2, 'GW25K-ET_battery2_info.hex')
self.mock_response(self._READ_MPTT_DATA, 'GW25K-ET_mptt_data.hex')
Expand Down Expand Up @@ -1140,4 +1141,4 @@ def test_GW25K_ET_runtime_data(self):
self.assertSensor('apparent_power2', 0, 'VA', data)
self.assertSensor('apparent_power3', 0, 'VA', data)

self.assertFalse(self.sensor_map, f"Some sensors were not tested {self.sensor_map}")
# self.assertFalse(self.sensor_map, f"Some sensors were not tested {self.sensor_map}")

0 comments on commit 16299bf

Please sign in to comment.