-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Stylesheets #465
Update Stylesheets #465
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just remove/update the debug log.
} | ||
|
||
importBuilder.append(" ] }"); | ||
Log.d("sarah", "IMPORT STR: " + importBuilder.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello sarah :D
I guess put for debugging purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:) Removed
} | ||
|
||
@Override public int getLabelCount() { | ||
return 12; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this 11 or 12?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its zero indexed and there are 12 label levels for bubble wrap: https://mapzen.com/documentation/cartography/themes/#bubble-wrap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops :D
Overview
Migrates all house styles to latest themed releases, upgrades Tangram, and expands style switcher sample to allow easily testing themes
Proposed Changes
ThemedMapStyle
ZincStyle
(will be removed in a future release Remove Deprecated Classes/Methods #466)submodules
task to point to updated stylesheet pathCloses #461