Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamped the project #1

Merged
merged 12 commits into from
Jun 17, 2024
Merged

Revamped the project #1

merged 12 commits into from
Jun 17, 2024

Conversation

jonathanlurie
Copy link
Collaborator

@jonathanlurie jonathanlurie commented Jun 7, 2024 •
edited by jira bot
Loading

petrsloup
petrsloup reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@petrsloup petrsloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is a forgotten api key in the cities demo
  • Does it make sense to include the logos? Wouldn't it be better to use the CDN logos right away?

@petrsloup
Copy link
Member

  • There is a forgotten api key in the cities demo
  • Does it make sense to include the logos? Wouldn't it be better to use the CDN logos right away?

Well, it probably doesn't matter here if the repo becomes public...

@petrsloup petrsloup merged commit 39ee2b1 into main Jun 17, 2024
1 check passed
@petrsloup petrsloup deleted the RD-245 branch June 17, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrsloup petrsloup petrsloup left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanlurie @petrsloup