Replace OfflineIndexObserver with AbstractSearchEngine.offlineEngineReady flag #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e AbstractSearchEngine.offlineEngineReady bool
mikeringrose
previously approved these changes
Apr 15, 2024
No, this is the entry point. |
- Add assertions for failing condition to have errors
…ce-offlineindexobserver-with-offlineengineready-flag Conflicts: CHANGELOG.md - Accept both changelog additions
- Revert offline testNoData test
|
Closing because the best way to use offline search will be with an OfflineIndexObserver and to work on a more thorough reference demo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes offline search readiness without relying on setting up an OfflineIndexObserver
offlineEngineReady: Boolflag becomes true.Checklist
CHANGELOG