Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SSDK-643] Upgrade MapboxCoreSearch #196

Merged
merged 4 commits into from
Mar 22, 2024
Merged

[SSDK-643] Upgrade MapboxCoreSearch #196

merged 4 commits into from
Mar 22, 2024

Conversation

aokj4ck
Copy link
Contributor

@aokj4ck aokj4ck commented Mar 21, 2024 •
edited
Loading

Description

Fixes https://mapbox.atlassian.net/browse/SSDK-643

  • Upgrade MapboxCoreSearch to v2.0.0-alpha.14, built with Xcode 15.3
  • This should resolve build issues with Xcode 15.3
  • Add SearchResultAccuracy.proximate case which "is a known address point but does not intersect a known rooftop/parcel."

Checklist

  • Update CHANGELOG

Screenshots

Xcode 14 Validation Xcode 15 Validation
Screenshot 2024-03-21 at 10 34 33 Screenshot 2024-03-21 at 10 42 15

globaltrouble
globaltrouble previously approved these changes Mar 21, 2024
View reviewed changes
@aokj4ck aokj4ck mentioned this pull request Mar 21, 2024
Closed
@aokj4ck aokj4ck marked this pull request as ready for review March 21, 2024 15:14
@aokj4ck aokj4ck requested review from a team as code owners March 21, 2024 15:14
@aokj4ck
Copy link
Contributor Author

aokj4ck commented Mar 21, 2024

@aokj4ck
Copy link
Contributor Author

aokj4ck commented Mar 21, 2024

This build has succeeded on Xcode 15.3.

Screenshot 2024-03-21 at 12 53 43

@aokj4ck aokj4ck merged commit e838f69 into main Mar 22, 2024
5 checks passed
@aokj4ck aokj4ck deleted the SSDK-643-upgrade-search-core-alpha.14 branch March 22, 2024 12:46
@aokj4ck aokj4ck restored the SSDK-643-upgrade-search-core-alpha.14 branch March 22, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globaltrouble globaltrouble globaltrouble approved these changes

@kried kried Awaiting requested review from kried kried is a code owner automatically assigned from mapbox/search-sdk

@ahmedaly16 ahmedaly16 Awaiting requested review from ahmedaly16 ahmedaly16 is a code owner automatically assigned from mapbox/search-sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aokj4ck @globaltrouble