Add distance formatter field to MapboxSearchUI.Configuration #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovalex
reviewed
Feb 8, 2024
…istanceFormatter-field-to-configuration Conflicts: CHANGELOG.md
…istanceFormatter-field-to-configuration Conflicts: CHANGELOG.md
azarovalex
approved these changes
Feb 13, 2024
aokj4ck
added a commit
that referenced
this pull request
Apr 5, 2024
### Description Fixes #168 - Add an optional [MKDistanceFormatter](https://developer.apple.com/documentation/mapkit/mkdistanceformatter) parameter to Configuration that will be used in the suggestion results to format the distance. - If no value is provided then the default system behavior of auto-detecting the device locale for the formatter style will be used. - Update the Examples/SearchExample.xcworkspace project with sample code ### Checklist - [x] Update `CHANGELOG` ### Screenshots | With nil value | With a custom formatter in locale en_US | | -- | -- | |  |  | Listing for "With a nil value" screenshot in SimpleUISearchViewController ```swift var configuration = Configuration() ``` Listing for "With a custom formatter in locale en_US" screenshot in SimpleUISearchViewController ```swift let formatter = MKDistanceFormatter() formatter.units = .metric formatter.unitStyle = .full var configuration = Configuration( distanceFormatter: formatter ) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #168
Checklist
CHANGELOGScreenshots
Listing for "With a nil value" screenshot in SimpleUISearchViewController
Listing for "With a custom formatter in locale en_US" screenshot in SimpleUISearchViewController