Update SearchExample attribution and logo placement #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to top left (out of SearchUI) #165
azarovalex
approved these changes
Feb 8, 2024
azarovalex
reviewed
Feb 8, 2024
Comment on lines
+33
to
+39
| let scalarX = mapView.ornaments.logoView.bounds.maxX + 12 | ||
| mapView.ornaments.options.scaleBar = ScaleBarViewOptions( | ||
| position: .topLeading, | ||
| margins: CGPoint(x: scalarX, y: 0), | ||
| visibility: .visible, | ||
| useMetricUnits: false | ||
| ) |
There was a problem hiding this comment.
I think we can just hide scale bar, not like it's important to the sample
There was a problem hiding this comment.
Yes it is not essential although I would like to leave it because the margin behavior is not entirely obvious so this helps demonstrate what is possible.
azarovalex
approved these changes
Feb 9, 2024
aokj4ck
added a commit
that referenced
this pull request
Apr 5, 2024
… to top left (out of SearchUI) #165 (#170) ### Description Fixes #165 - Update SearchExample > Integrate SearchUI module to demonstrate correct attribution on a Mapbox MapView when using the SearchUI - Attribution guide: https://docs.mapbox.com/help/getting-started/attribution/#mapbox-maps-sdk-for-ios ### Checklist - ~[ ] Update `CHANGELOG`~ | Before | After | After (iPhone SE) | | -- | -- | -- | |  |  |  |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #165
Checklist
[ ] UpdateCHANGELOG