Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve failing tests with pandas>=2.2 #31

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

manmartgarc
Copy link
Owner

Fixes failing tests that were due to a change in
pandas>=2.2 related to using .apply() on grouped-by objects. Fixes a bunch of warnings related to dubious type mixing within columns. I also finally fixes the import issue due to using the same name everywhere and adds a unit test for verify that the import is not broken again.

It also deprecates 3.8 since it's almost EOL.

Fixes failing tests that were due to a change in
[pandas>=2.2](https://pandas.pydata.org/docs/reference/api/pandas.core.groupby.DataFrameGroupBy.apply.html)
related to using `.apply()` on grouped-by objects. Fixes a bunch of
warnings related to dubious type mixing within columns. I also finally
fixes the import issue due to using the same name everywhere and adds a
unit test for verify that the import is not broken again.

It also deprecates 3.8 since it's almost EOL.
@manmartgarc manmartgarc marked this pull request as ready for review April 28, 2024 07:33
@manmartgarc manmartgarc self-assigned this Apr 28, 2024
@manmartgarc manmartgarc merged commit c023860 into main Apr 28, 2024
4 checks passed
@manmartgarc manmartgarc deleted the fix-pandas branch April 28, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant