Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 remove all upload methods #63

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

boredland
Copy link
Collaborator

@boredland boredland commented May 7, 2024

They aren't used anywhere as far as I know (did go through lots of repos).

Complexity like this should be implemented on the users side.

closes #22 as a side-effect

@boredland boredland changed the title chore: remove all upload methods except github releases chore: remove all upload methods and gpg signing May 7, 2024
@boredland boredland requested a review from romangg May 7, 2024 07:54
@boredland boredland marked this pull request as ready for review May 7, 2024 07:54
@boredland boredland changed the title chore: remove all upload methods and gpg signing 🔥 remove all upload methods and gpg signing May 7, 2024
They aren't used anywhere (gone through lots of repos) to my knowledge.

Logic like this should be handled outside of this actions.
@boredland boredland force-pushed the boredland-remove-release-channels branch from 91540fa to 1298181 Compare May 7, 2024 11:28
@boredland boredland changed the title 🔥 remove all upload methods and gpg signing 🔥 remove all upload methods May 7, 2024
@boredland boredland merged commit 4a9d54e into main May 7, 2024
2 checks passed
@philmmanjaro
Copy link
Member

Don't get it. upload-cdn77-s3 is used for the stable ISOs to upload to our CDN network. Also the sourceforge upload.

philmmanjaro added a commit that referenced this pull request May 7, 2024
@boredland
Copy link
Collaborator Author

Don't get it. upload-cdn77-s3 is used for the stable ISOs to upload to our CDN network. Also the sourceforge upload.

Didn't find that in the 100000 clones of this action you set up. Which one is it?

@philmmanjaro
Copy link
Member

Those I use to build the stable ISOs which can be found here:

https://github.com/manjaro/citestbed/blob/master/.github/workflows/iso_build.yaml
https://github.com/manjaro/citestbed/blob/master/.github/workflows/iso_build_lts.yaml

They are used for the stable ISO files.

@boredland
Copy link
Collaborator Author

citestbed isn't a testbed, but uploads our stable images? wow.

@boredland
Copy link
Collaborator Author

boredland commented May 7, 2024

anyway: is still think this shouldn't be part of this action, as it couples building the images with releasing them. IMO a proper process would be:

  1. build and pre-release using this action
  2. manual review
  3. approval for release and uploading to the CDNs

@romangg
Copy link
Member

romangg commented May 7, 2024

IMO we need better docs about what repos there are all and then in general reducing the number of them. It can't be, that it's so difficult to work with them.

Can we find some time after stable snap to discuss that more @philmmanjaro? Also then we can hopefully remerge the PR here, at least the parts of it which remove stuff taht are really not needed anymore.

@philmmanjaro
Copy link
Member

CDNs don't list the images so a review is done on those images. Sourceforge is only optional and not promoted when we do a release.

@boredland
Copy link
Collaborator Author

by the way, the only docs in that "testbed" repo:

here we test some CI ideas

@philmmanjaro
Copy link
Member

There are some outdated upload methods we don't use anymore, but s3 and sf is still used.

boredland added a commit to manjaro-contrib/action-buildiso that referenced this pull request May 7, 2024
@philmmanjaro
Copy link
Member

@oberon-manjaro Can you check again which lines for CDN77 upload is not needed anymore? I think we can drop OSDN upload as we don't use that for ages. SF is still our backup for download archives, even they always send emails that we use too much storage on their end ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI test uploads version should start with a dot
3 participants