[todo] 멘토링 취소 모달 개발 #235
Merged
[todo] 멘토링 취소 모달 개발 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falconlee236
added
bug
falconlee236
requested review from
koreanddinghwan,
JuneParkCode,
obvoso and
jinaji
This was
linked to
issues
Oct 3, 2023
Closed
jinaji
approved these changes
Oct 3, 2023
obvoso
reviewed
Oct 4, 2023
JuneParkCode
requested changes
Oct 4, 2023
JuneParkCode
approved these changes
Oct 4, 2023
obvoso
reviewed
Oct 4, 2023
obvoso
pushed a commit
to obvoso/42manito-front
that referenced
this pull request
Oct 27, 2023
* [fix]: index.tsx 메인 페이지에 Cancel Modal 적용 * [fix]: Mentoring index.tsx에 Cancel Modal 적용 * [fix]: Reservation page에 Cancel Modal 적용 * [fix]: Home page에 Feedback Modal 적용 manito42#157 * [fix]: CANCLE읋 CANCEL로 변환 * [fix]: Success, Fail 문자열 변경 * [fix]: TextArea 에서 최대 문자 길이 제한 변경 * [fix]: useState 초기값 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
해당 모달은 components/Cancel/CancelModal.tsx에 위치해 있습니다.
일단 취소 모달의 Select 항목의 내용은 기존 [todo] 멘토링 취소 모달 개발 #190 에서 말해주셨던 항목을 참고했습니다.
해당 모달은 page/index.tsx, page/Mentorings/index.tsx, page/reservation/[reservationId].tsx에 추가했습니다.
@jinaji 님이 [feat]: reservation page #223 #230 에서 말씀하셨던 [todo] home 에서 reservation 의 하위 모달도 뜰 수 있도록 변경 #207 이슈를 처리했습니다.
참고사항
취소 모달의 Select항목의 추가 아이디어가 안떠올라서 일단 3개만 했는데, 추가적으로 넣으면 좋을 것같다는 의견 있으면 남겨주세요
ScreenShot