Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#35] [Chore] UI Integration Test - Sign In page #62

Merged
merged 3 commits into from
Aug 28, 2023
Merged

[#35] [Chore] UI Integration Test - Sign In page #62

merged 3 commits into from
Aug 28, 2023

Conversation

manh-t
Copy link
Owner

@manh-t manh-t commented Jul 4, 2023 •
edited
Loading

Close #35

What happened 👀

  • Add the fake response json files for:
    • POST api/v1/oauth/token
    • GET api/v1/surveys
    • GET api/v1/me
  • Add the test cases for SignIn screen:
    • When the user submits the valid submission, he should be navigated to Dashboard screen
    • When the user submits the invalid submission, he should see the Alert dialog.
    • When the user submits the submission but failed on the validation step, he should see the error popup from the browser.

Insight 📝

N/A

Proof Of Work 📹

image

@manh-t manh-t added this to the 0.4.0 milestone Jul 4, 2023
@manh-t manh-t self-assigned this Jul 4, 2023
@manh-t
Copy link
Owner Author

manh-t commented Jul 4, 2023 •
edited
Loading

🚀 Deployed on https://64ec76e213ef6f02c5f4ba7e--manh-react-survey.netlify.app

@manh-t manh-t temporarily deployed to pull request July 4, 2023 08:21 Inactive
@manh-t
Copy link
Owner Author

manh-t commented Jul 4, 2023 •
edited
Loading

Messages
📖 Congrats, coverage is good

Coverage in All Files

File Line Coverage Statement Coverage Function Coverage Branch Coverage
src/screens/Survey/index.tsx (1/3) 33% (1/3) 33% (0/1) 0% (0/0) NaN%
src/tests/error.ts (2/3) 67% (2/3) 67% (1/2) 50% (1/3) 33%
src/../Content/index.tsx (12/15) 80% (12/15) 80% (5/7) 71% (5/9) 56%
src/../Dashboard/index.tsx (10/12) 83% (10/12) 83% (5/7) 71% (9/10) 90%
src/App.tsx (3/3) 100% (3/3) 100% (1/1) 100% (0/0) NaN%
src/index.tsx (3/3) 100% (3/3) 100% (0/0) NaN% (0/0) NaN%
src/../Authentication/index.ts (2/2) 100% (2/2) 100% (1/1) 100% (0/0) NaN%
src/adapters/Base/index.ts (8/8) 100% (8/8) 100% (2/2) 100% (2/2) 100%
src/adapters/BaseAuth/index.ts (10/10) 100% (10/10) 100% (4/4) 100% (2/2) 100%
src/adapters/Survey/index.ts (1/1) 100% (1/1) 100% (1/1) 100% (0/0) NaN%
src/adapters/User/index.ts (1/1) 100% (1/1) 100% (1/1) 100% (0/0) NaN%
src/components/Alert/index.tsx (3/3) 100% (3/3) 100% (2/2) 100% (0/0) NaN%
src/../index.tsx (3/3) 100% (3/3) 100% (1/1) 100% (2/2) 100%
src/../Empty/index.tsx (3/3) 100% (3/3) 100% (1/1) 100% (0/0) NaN%
src/../Header/index.tsx (3/3) 100% (3/3) 100% (1/1) 100% (9/9) 100%
Other (28 more) (170/170) 100% (170/170) 100% (60/60) 100% (39/41) 95%
Total (235/243) 97% (235/243) 97% (86/92) 93% (69/78) 88%

Generated by 🚫 dangerJS against 11c3ca8

@manh-t manh-t changed the title [Chore] UI Integration Test - Sign In page [#35] [Chore] UI Integration Test - Sign In page Jul 4, 2023
@manh-t manh-t mentioned this pull request Jul 19, 2023
Merged
@manh-t manh-t added the @0.4.0 label Jul 27, 2023
@manh-t manh-t marked this pull request as draft July 28, 2023 02:43
@manh-t manh-t force-pushed the feature/14-integrate-surveys-in-dashboard-page branch from c30839b to a758024 Compare July 28, 2023 03:32
@manh-t manh-t force-pushed the chore/35-integration-sign-in-screen branch from 9f9c6d0 to 3f5b0e4 Compare July 28, 2023 04:20
@manh-t manh-t temporarily deployed to pull request July 28, 2023 04:21 Inactive
@manh-t manh-t marked this pull request as ready for review July 28, 2023 04:27
@manh-t manh-t requested a review from hoangmirs as a code owner July 28, 2023 04:27
tyrro
tyrro reviewed Aug 28, 2023
View reviewed changes
cypress/e2e/SignIn/index.spec.ts Outdated Show resolved Hide resolved
cypress/e2e/SignIn/index.spec.ts Outdated Show resolved Hide resolved
cypress/e2e/SignIn/index.spec.ts Outdated Show resolved Hide resolved
@manh-t manh-t force-pushed the chore/35-integration-sign-in-screen branch from 3f5b0e4 to 63408c1 Compare August 28, 2023 04:07
@manh-t manh-t temporarily deployed to pull request August 28, 2023 04:09 Inactive
@manh-t manh-t force-pushed the feature/14-integrate-surveys-in-dashboard-page branch from 90da065 to 8bf88ce Compare August 28, 2023 07:25
@manh-t manh-t force-pushed the chore/35-integration-sign-in-screen branch from 63408c1 to 2b93d31 Compare August 28, 2023 08:15
@manh-t manh-t temporarily deployed to pull request August 28, 2023 08:17 Inactive
nvminhtue
nvminhtue approved these changes Aug 28, 2023
View reviewed changes
cypress/e2e/SignIn/index.spec.ts Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
Base automatically changed from feature/14-integrate-surveys-in-dashboard-page to develop August 28, 2023 10:11
@manh-t manh-t force-pushed the chore/35-integration-sign-in-screen branch from 2b93d31 to af96741 Compare August 28, 2023 10:12
@manh-t manh-t temporarily deployed to pull request August 28, 2023 10:13 Inactive
@manh-t manh-t force-pushed the chore/35-integration-sign-in-screen branch from af96741 to c69da21 Compare August 28, 2023 10:16
@manh-t manh-t temporarily deployed to pull request August 28, 2023 10:18 Inactive
@manh-t manh-t temporarily deployed to pull request August 28, 2023 10:28 Inactive
@manh-t manh-t merged commit a630dab into develop Aug 28, 2023
2 checks passed
@manh-t manh-t deleted the chore/35-integration-sign-in-screen branch August 28, 2023 10:35
@manh-t manh-t mentioned this pull request Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrro tyrro tyrro approved these changes

@nvminhtue nvminhtue nvminhtue approved these changes

@hoangmirs hoangmirs Awaiting requested review from hoangmirs hoangmirs is a code owner

Assignees

@manh-t manh-t

Labels
type: chore @0.4.0
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

[Chore] UI Integration Test - Sign In page
3 participants
@manh-t @tyrro @nvminhtue