Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#14] [Integrate] As a user, I can see the surveys on the Dashboard page #61

Merged
merged 9 commits into from
Aug 28, 2023
Merged

[#14] [Integrate] As a user, I can see the surveys on the Dashboard page #61

merged 9 commits into from
Aug 28, 2023

Conversation

manh-t
Copy link
Owner

@manh-t manh-t commented Jun 30, 2023 •
edited
Loading

Close #14

What happened 👀

  • Add moment package to support parsing date time.
  • Fill surveys and the user info from API to the Dashboard screen.
  • When fetching the surveys for the first time, we show Shimmer.
  • We show the Dashboard Empty in case: the survey list is empty or getting an error while fetching the surveys.
  • After fetching the surveys successfully and the surveys have data, we show Dashboard Content.
  • When clicking on the Arrow right button, we navigate to the Survey Detail screen.

Insight 📝

  • The Survey Detail screen now is just a blank page, we will implement this screen in another task.

Proof Of Work 📹

Screen.Recording.2023-07-28.at.11.06.55.mov

@manh-t manh-t added this to the 0.4.0 milestone Jun 30, 2023
@manh-t manh-t self-assigned this Jun 30, 2023
@manh-t
Copy link
Owner Author

manh-t commented Jun 30, 2023 •
edited
Loading

🚀 Deployed on https://64ec72320ade10029735e53c--manh-react-survey.netlify.app

@manh-t manh-t temporarily deployed to pull request June 30, 2023 07:21 Inactive
@manh-t manh-t temporarily deployed to pull request July 3, 2023 09:14 Inactive
@manh-t
Copy link
Owner Author

manh-t commented Jul 3, 2023 •
edited
Loading

Messages
📖 Congrats, coverage is good

Coverage in All Files

File Line Coverage Statement Coverage Function Coverage Branch Coverage
src/screens/Survey/index.tsx (1/3) 33% (1/3) 33% (0/1) 0% (0/0) NaN%
src/../v1/requestManager.ts (9/18) 50% (9/18) 50% (4/6) 67% (1/3) 33%
src/config/index.ts (5/9) 56% (5/9) 56% (0/3) 0% (0/4) 0%
src/tests/error.ts (2/3) 67% (2/3) 67% (1/2) 50% (1/3) 33%
src/screens/SignIn/index.tsx (12/16) 75% (12/16) 75% (3/6) 50% (8/8) 100%
src/../Content/index.tsx (12/15) 80% (12/15) 80% (5/7) 71% (5/9) 56%
src/../index.tsx (4/5) 80% (4/5) 80% (2/2) 100% (1/2) 50%
src/../Dashboard/index.tsx (10/12) 83% (10/12) 83% (5/7) 71% (9/10) 90%
src/App.tsx (3/3) 100% (3/3) 100% (1/1) 100% (0/0) NaN%
src/index.tsx (3/3) 100% (3/3) 100% (0/0) NaN% (0/0) NaN%
src/../Authentication/index.ts (2/2) 100% (2/2) 100% (1/1) 100% (0/0) NaN%
src/adapters/Base/index.ts (8/8) 100% (8/8) 100% (2/2) 100% (2/2) 100%
src/adapters/BaseAuth/index.ts (10/10) 100% (10/10) 100% (4/4) 100% (2/2) 100%
src/adapters/Survey/index.ts (1/1) 100% (1/1) 100% (1/1) 100% (0/0) NaN%
src/adapters/User/index.ts (1/1) 100% (1/1) 100% (1/1) 100% (0/0) NaN%
Other (28 more) (134/134) 100% (134/134) 100% (48/48) 100% (34/35) 97%
Total (217/243) 89% (217/243) 89% (78/92) 85% (63/78) 81%

Generated by 🚫 dangerJS against 1550e29

@manh-t manh-t force-pushed the feature/13-backend-get-user-info branch from 0c54c45 to f62061f Compare July 4, 2023 03:29
@manh-t manh-t force-pushed the feature/14-integrate-surveys-in-dashboard-page branch from 2ddc25b to c30839b Compare July 4, 2023 03:30
@manh-t manh-t temporarily deployed to pull request July 4, 2023 03:32 Inactive
@manh-t manh-t added the @0.4.0 label Jul 27, 2023
@manh-t manh-t marked this pull request as draft July 28, 2023 02:43
@manh-t manh-t force-pushed the feature/13-backend-get-user-info branch from f62061f to 747c0a4 Compare July 28, 2023 02:54
@manh-t manh-t force-pushed the feature/14-integrate-surveys-in-dashboard-page branch from c30839b to a758024 Compare July 28, 2023 03:32
@manh-t manh-t temporarily deployed to pull request July 28, 2023 03:33 Inactive
@manh-t manh-t temporarily deployed to pull request July 28, 2023 03:54 Inactive
@manh-t manh-t force-pushed the feature/14-integrate-surveys-in-dashboard-page branch from 59445d3 to edc3325 Compare July 28, 2023 04:00
@manh-t manh-t temporarily deployed to pull request July 28, 2023 04:01 Inactive
@manh-t manh-t marked this pull request as ready for review July 28, 2023 04:09
@manh-t manh-t requested a review from hoangmirs as a code owner July 28, 2023 04:09
@manh-t manh-t marked this pull request as draft July 28, 2023 04:10
@manh-t manh-t marked this pull request as ready for review July 28, 2023 04:18
nvminhtue
nvminhtue reviewed Jul 28, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/components/Dashboard/Content/index.test.tsx Outdated Show resolved Hide resolved
src/components/Dashboard/Content/index.tsx Outdated Show resolved Hide resolved
src/components/Dashboard/Content/index.tsx Outdated Show resolved Hide resolved
src/components/Dashboard/Content/index.tsx Show resolved Hide resolved
src/components/Dashboard/Empty/index.tsx Outdated Show resolved Hide resolved
src/components/Dashboard/Header/index.tsx Outdated Show resolved Hide resolved
src/helpers/datetime.ts Outdated Show resolved Hide resolved
@manh-t
Copy link
Owner Author

manh-t commented Aug 28, 2023

@nvminhtue @tyrro updated all in 90da065 🙏

@manh-t manh-t temporarily deployed to pull request August 28, 2023 03:50 Inactive
Base automatically changed from feature/13-backend-get-user-info to develop August 28, 2023 04:33
hoangmirs
hoangmirs reviewed Aug 28, 2023
View reviewed changes
package.json Show resolved Hide resolved
src/components/Dashboard/Content/index.test.tsx Outdated Show resolved Hide resolved
src/components/Dashboard/Content/index.tsx Outdated Show resolved Hide resolved
src/helpers/datetime.ts Outdated Show resolved Hide resolved
@manh-t manh-t force-pushed the feature/14-integrate-surveys-in-dashboard-page branch from 90da065 to 8bf88ce Compare August 28, 2023 07:25
@manh-t manh-t temporarily deployed to pull request August 28, 2023 07:27 Inactive
@manh-t manh-t requested a review from hoangmirs August 28, 2023 07:33
@manh-t manh-t temporarily deployed to pull request August 28, 2023 07:56 Inactive
nvminhtue
nvminhtue approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@nvminhtue nvminhtue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, the rest is LGTM

src/components/Dashboard/Content/index.tsx Outdated Show resolved Hide resolved
src/components/Dashboard/Content/index.tsx Outdated Show resolved Hide resolved
src/components/Dashboard/Header/index.tsx Outdated Show resolved Hide resolved
@manh-t manh-t temporarily deployed to pull request August 28, 2023 10:03 Inactive
@manh-t manh-t force-pushed the feature/14-integrate-surveys-in-dashboard-page branch from 29fe872 to 1550e29 Compare August 28, 2023 10:07
@manh-t manh-t temporarily deployed to pull request August 28, 2023 10:08 Inactive
@manh-t manh-t merged commit b961eff into develop Aug 28, 2023
2 checks passed
@manh-t manh-t deleted the feature/14-integrate-surveys-in-dashboard-page branch August 28, 2023 10:11
@manh-t manh-t mentioned this pull request Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvminhtue nvminhtue nvminhtue approved these changes

@hoangmirs hoangmirs hoangmirs approved these changes

@tyrro tyrro tyrro approved these changes

Assignees

@manh-t manh-t

Labels
type: feature @0.4.0
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

[Integrate] As a user, I can see the surveys on the Dashboard page
4 participants
@manh-t @hoangmirs @tyrro @nvminhtue