Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#10] [UI] As a user, I can see the shimmer loading on Dashboard page #53

Merged
merged 3 commits into from
Jul 25, 2023
Merged

[#10] [UI] As a user, I can see the shimmer loading on Dashboard page #53

merged 3 commits into from
Jul 25, 2023

Conversation

manh-t
Copy link
Owner

@manh-t manh-t commented Jun 21, 2023

Close #10

What happened 👀

  • Add Shimmer component to display the shimmer. It is inspired by this source
  • Add shouldShowShimmer to DashboardHeader so the components in the header can display as the shimmer.
  • Create DashboardContent component, but only implement the Shimmer for now.

Insight 📝

N/A

Proof Of Work 📹

Screen.Recording.2023-06-21.at.16.07.07.mov

@manh-t manh-t added this to the 0.3.0 milestone Jun 21, 2023
@manh-t manh-t requested a review from nvminhtue as a code owner June 21, 2023 09:08
@manh-t manh-t self-assigned this Jun 21, 2023
@manh-t manh-t requested a review from tyrro as a code owner June 21, 2023 09:08
@manh-t manh-t force-pushed the feature/10-ui-shimmer-loading-on-dashboard branch from 84b9af4 to 18f92c6 Compare June 21, 2023 09:08
@manh-t
Copy link
Owner Author

manh-t commented Jun 21, 2023 •
edited
Loading

🚀 Deployed on https://64bdf9ca3981b214731218fa--manh-react-survey.netlify.app

@manh-t manh-t temporarily deployed to pull request June 21, 2023 09:10 Inactive
@manh-t
Copy link
Owner Author

manh-t commented Jun 21, 2023 •
edited
Loading

Messages
📖 Coverage is a little low, take a look

Coverage in All Files

File Line Coverage Statement Coverage Function Coverage Branch Coverage
src/../v1/requestManager.ts (9/18) 50% (9/18) 50% (4/6) 67% (1/3) 33%
src/../Dashboard/index.tsx (1/2) 50% (1/2) 50% (0/1) 0% (0/0) NaN%
src/config/index.ts (5/9) 56% (5/9) 56% (0/3) 0% (0/4) 0%
src/tests/error.ts (2/3) 67% (2/3) 67% (1/2) 50% (1/3) 33%
src/screens/SignIn/index.tsx (12/16) 75% (12/16) 75% (3/6) 50% (6/6) 100%
src/helpers/authentication.ts (10/11) 91% (10/11) 91% (3/3) 100% (1/2) 50%
src/App.tsx (3/3) 100% (3/3) 100% (1/1) 100% (0/0) NaN%
src/index.tsx (3/3) 100% (3/3) 100% (0/0) NaN% (0/0) NaN%
src/../Authentication/index.ts (2/2) 100% (2/2) 100% (1/1) 100% (0/0) NaN%
src/adapters/Base/index.ts (7/7) 100% (7/7) 100% (2/2) 100% (2/2) 100%
src/components/Alert/index.tsx (3/3) 100% (3/3) 100% (2/2) 100% (0/0) NaN%
src/../Content/index.tsx (3/3) 100% (3/3) 100% (1/1) 100% (0/0) NaN%
src/../Empty/index.tsx (2/2) 100% (2/2) 100% (1/1) 100% (0/0) NaN%
src/../Header/index.tsx (2/2) 100% (2/2) 100% (1/1) 100% (9/9) 100%
src/../index.tsx (3/3) 100% (3/3) 100% (1/1) 100% (0/0) NaN%
Other (14 more) (65/65) 100% (65/65) 100% (23/23) 100% (12/12) 100%
Total (132/152) 87% (132/152) 87% (44/54) 81% (32/41) 78%

Generated by 🚫 dangerJS against 1217084

@manh-t manh-t force-pushed the chore/bump-version-to-0.3.0 branch from 6b4d917 to d583322 Compare June 24, 2023 04:19
@manh-t manh-t force-pushed the feature/10-ui-shimmer-loading-on-dashboard branch from 18f92c6 to e896e59 Compare June 24, 2023 04:21
@manh-t manh-t temporarily deployed to pull request June 24, 2023 04:22 Inactive
@manh-t manh-t force-pushed the chore/bump-version-to-0.3.0 branch from d583322 to e150003 Compare June 27, 2023 10:10
@manh-t manh-t force-pushed the feature/10-ui-shimmer-loading-on-dashboard branch from e896e59 to 3ff91ee Compare June 27, 2023 10:12
@manh-t manh-t temporarily deployed to pull request June 27, 2023 10:14 Inactive
@manh-t manh-t temporarily deployed to pull request June 27, 2023 10:28 Inactive
@manh-t manh-t force-pushed the chore/bump-version-to-0.3.0 branch from e150003 to a13caa4 Compare July 4, 2023 03:20
@manh-t manh-t force-pushed the feature/10-ui-shimmer-loading-on-dashboard branch from 3858d23 to a8c3fa8 Compare July 4, 2023 03:22
@manh-t manh-t temporarily deployed to pull request July 4, 2023 03:24 Inactive
@manh-t manh-t force-pushed the chore/bump-version-to-0.3.0 branch from a13caa4 to fe42775 Compare July 19, 2023 06:47
@manh-t manh-t force-pushed the feature/10-ui-shimmer-loading-on-dashboard branch from a8c3fa8 to 10cfe67 Compare July 19, 2023 06:50
@manh-t manh-t requested a review from hoangmirs July 19, 2023 06:50
@manh-t manh-t temporarily deployed to pull request July 19, 2023 06:51 Inactive
Base automatically changed from chore/bump-version-to-0.3.0 to develop July 19, 2023 07:33
nvminhtue
nvminhtue reviewed Jul 20, 2023
View reviewed changes
src/components/Dashboard/Content/index.tsx Outdated Show resolved Hide resolved
src/components/Dashboard/Content/index.test.tsx Outdated Show resolved Hide resolved
src/components/Dashboard/Header/index.tsx Show resolved Hide resolved
src/components/Shimmer/index.test.tsx Outdated Show resolved Hide resolved
src/components/Shimmer/index.tsx Outdated Show resolved Hide resolved
tyrro
tyrro approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@tyrro tyrro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Tyson's changes!

src/components/Shimmer/index.tsx Outdated Show resolved Hide resolved
@manh-t manh-t temporarily deployed to pull request July 24, 2023 04:10 Inactive
@manh-t manh-t mentioned this pull request Jul 24, 2023
Open
@manh-t
Copy link
Owner Author

manh-t commented Jul 24, 2023

@tyrro @nvminhtue fixed and updated 🙏

@manh-t manh-t requested a review from nvminhtue July 24, 2023 04:15
@manh-t manh-t merged commit 1f9341d into develop Jul 25, 2023
2 checks passed
@manh-t manh-t deleted the feature/10-ui-shimmer-loading-on-dashboard branch July 25, 2023 06:48
@manh-t manh-t mentioned this pull request Jul 27, 2023
Merged
@manh-t manh-t added the @0.3.0 label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangmirs hoangmirs hoangmirs approved these changes

@tyrro tyrro tyrro approved these changes

@nvminhtue nvminhtue Awaiting requested review from nvminhtue nvminhtue is a code owner

Assignees

@manh-t manh-t

Labels
high-priority type: feature @0.3.0
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

[UI] As a user, I can see the shimmer loading on Dashboard page
4 participants
@manh-t @hoangmirs @tyrro @nvminhtue