Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#6] [UI] As a user, I can see the Sign In page #42

Merged
merged 11 commits into from
Jun 30, 2023
Merged

[#6] [UI] As a user, I can see the Sign In page #42

merged 11 commits into from
Jun 30, 2023

Conversation

manh-t
Copy link
Owner

@manh-t manh-t commented Jun 12, 2023 •
edited
Loading

Close #6

What happened 👀

  • Ignore tailwind in stylelint
  • Remove sample code
  • Create SignInScreen
  • Write unittest.

Insight 📝

I use tailwind to apply the styles to the components, and I create some reusable attributes to work with tailwind.

Proof Of Work 📹

image

Check the Netlify link below.

@manh-t manh-t added this to the 0.1.0 milestone Jun 12, 2023
@manh-t manh-t self-assigned this Jun 12, 2023
@manh-t
Copy link
Owner Author

manh-t commented Jun 12, 2023 •
edited
Loading

🚀 Deployed on https://649e50e8f120a02951095552--manh-react-survey.netlify.app

@manh-t manh-t temporarily deployed to pull request June 12, 2023 11:02 Inactive
@manh-t manh-t force-pushed the chore/5-create-deploy-workflow-to-deploy-app-to-production branch 2 times, most recently from 5dbc625 to 49cb33d Compare June 13, 2023 04:59
@manh-t manh-t force-pushed the feature/6-ui-sign-in-screen branch from 5ea773a to 8847e7f Compare June 13, 2023 07:38
@manh-t manh-t temporarily deployed to pull request June 13, 2023 07:39 Inactive
@manh-t manh-t temporarily deployed to pull request June 13, 2023 07:58 Inactive
@manh-t manh-t temporarily deployed to pull request June 13, 2023 09:13 Inactive
@manh-t manh-t temporarily deployed to pull request June 13, 2023 10:08 Inactive
@manh-t manh-t temporarily deployed to pull request June 13, 2023 10:18 Inactive
@manh-t
Copy link
Owner Author

manh-t commented Jun 13, 2023 •
edited
Loading

Messages
📖 Congrats, coverage is good

Coverage in All Files

File Line Coverage Statement Coverage Function Coverage Branch Coverage
src/App.tsx (3/3) 100% (3/3) 100% (1/1) 100% (0/0) NaN%
src/index.tsx (3/3) 100% (3/3) 100% (0/0) NaN% (0/0) NaN%
src/../index.tsx (3/3) 100% (3/3) 100% (1/1) 100% (0/0) NaN%
src/../TextInput/index.tsx (3/3) 100% (3/3) 100% (1/1) 100% (2/2) 100%
src/lib/requestManager.ts (5/5) 100% (5/5) 100% (2/2) 100% (1/1) 100%
src/routes/index.tsx (1/1) 100% (1/1) 100% (0/0) NaN% (0/0) NaN%
src/screens/SignIn/index.tsx (3/3) 100% (3/3) 100% (1/1) 100% (0/0) NaN%
Total (21/21) 100% (21/21) 100% (6/6) 100% (3/3) 100%

Generated by 🚫 dangerJS against c5133e8

@manh-t manh-t marked this pull request as ready for review June 13, 2023 10:19
@manh-t manh-t changed the title [#6] Create SignInScreen [#6] [UI] As a user, I can see the Sign In page Jun 13, 2023
@manh-t manh-t temporarily deployed to pull request June 14, 2023 03:32 Inactive
@manh-t manh-t force-pushed the chore/5-create-deploy-workflow-to-deploy-app-to-production branch from 49cb33d to 5bee3bd Compare June 14, 2023 07:21
@manh-t manh-t force-pushed the feature/6-ui-sign-in-screen branch from b29ec20 to cb7545d Compare June 14, 2023 07:36
@manh-t manh-t temporarily deployed to pull request June 14, 2023 07:37 Inactive
nvminhtue
nvminhtue reviewed Jun 19, 2023
View reviewed changes
.eslintrc.js Outdated Show resolved Hide resolved
src/components/ElevatedButton/index.tsx Outdated Show resolved Hide resolved
src/screens/SignIn/index.tsx Outdated Show resolved Hide resolved
src/screens/SignIn/index.tsx Show resolved Hide resolved
@nvminhtue
Copy link
Collaborator

image
Could you help me to clarify it?

@manh-t
Copy link
Owner Author

manh-t commented Jun 20, 2023

image Could you help me to clarify it?

Thanks for catching the issue. This is the issue related to autofill. Fixed in 5c478f2 🙏
image

@manh-t manh-t temporarily deployed to pull request June 20, 2023 03:39 Inactive
@manh-t manh-t force-pushed the feature/6-ui-sign-in-screen branch from 5c478f2 to cfecfc0 Compare June 20, 2023 03:43
@manh-t manh-t temporarily deployed to pull request June 20, 2023 03:44 Inactive
@nvminhtue
Copy link
Collaborator

nvminhtue commented Jun 20, 2023 •
edited
Loading

The spacing seems closer compared to the design. Please take a look at that and appropriately adjust.
The font also different, when the one in the design is (Neuzeit S LT Std)
image

@manh-t manh-t temporarily deployed to pull request June 21, 2023 03:06 Inactive
nvminhtue
nvminhtue approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@nvminhtue nvminhtue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Base automatically changed from chore/5-create-deploy-workflow-to-deploy-app-to-production to develop June 21, 2023 07:25
@manh-t manh-t force-pushed the feature/6-ui-sign-in-screen branch from 6be17d4 to 901d40d Compare June 21, 2023 07:27
@manh-t manh-t temporarily deployed to pull request June 21, 2023 07:29 Inactive
tyrro
tyrro requested changes Jun 26, 2023
View reviewed changes
src/screens/SignIn/index.tsx Outdated Show resolved Hide resolved
src/assets/stylesheets/application.scss Outdated Show resolved Hide resolved
src/components/ElevatedButton/index.tsx Show resolved Hide resolved
@manh-t manh-t temporarily deployed to pull request June 27, 2023 03:09 Inactive
@manh-t manh-t requested a review from tyrro June 27, 2023 03:09
tyrro
tyrro requested changes Jun 28, 2023
View reviewed changes
src/assets/stylesheets/application.scss Outdated Show resolved Hide resolved
src/assets/stylesheets/base/_tailwindcss.scss Outdated Show resolved Hide resolved
src/components/ElevatedButton/index.test.tsx Show resolved Hide resolved
src/components/ElevatedButton/index.tsx Outdated Show resolved Hide resolved
src/components/TextInput/index.test.tsx Show resolved Hide resolved
src/components/ElevatedButton/index.test.tsx Outdated Show resolved Hide resolved
src/components/ElevatedButton/index.tsx Outdated Show resolved Hide resolved
src/components/TextInput/index.test.tsx Show resolved Hide resolved
tyrro
tyrro requested changes Jun 28, 2023
View reviewed changes
src/screens/SignIn/index.tsx Outdated Show resolved Hide resolved
tailwind.config.js Show resolved Hide resolved
tyrro
tyrro requested changes Jun 28, 2023
View reviewed changes
src/components/ElevatedButton/index.tsx Outdated Show resolved Hide resolved
@manh-t manh-t requested a review from tyrro June 29, 2023 04:16
tyrro
tyrro approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@tyrro tyrro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've some last comments but the changes now LGTM! Well done!

src/components/ElevatedButton/index.tsx Show resolved Hide resolved
src/components/TextInput/index.test.tsx Show resolved Hide resolved
src/components/TextInput/index.tsx Show resolved Hide resolved
src/components/TextInput/index.tsx Outdated Show resolved Hide resolved
src/screens/SignIn/index.tsx Show resolved Hide resolved
@manh-t manh-t mentioned this pull request Jun 30, 2023
Open
@manh-t manh-t temporarily deployed to pull request June 30, 2023 03:50 Inactive
@manh-t manh-t merged commit c2e0d2b into develop Jun 30, 2023
@manh-t manh-t deleted the feature/6-ui-sign-in-screen branch June 30, 2023 03:51
@manh-t manh-t mentioned this pull request Jun 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrro tyrro tyrro approved these changes

@nvminhtue nvminhtue nvminhtue approved these changes

Assignees

@manh-t manh-t

Labels
high-priority type: feature
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

[UI] As a user, I can see the Sign In page
3 participants
@manh-t @nvminhtue @tyrro