Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ZimmermanTools Install #1123

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix ZimmermanTools Install #1123

merged 1 commit into from
Aug 27, 2024

Conversation

heap-s
Copy link
Contributor

@heap-s heap-s commented Aug 26, 2024

Currently all ZimmermanTools return a 404 when attempting to download them. This changes the server to the appropriate server "https://download.mikestammer.com/" for all 26 packages.

Copy link

google-cla bot commented Aug 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@heap-s
Copy link
Contributor Author

heap-s commented Aug 27, 2024

Resolves mandiant/flare-vm#607

@emtuls
Copy link
Member

emtuls commented Aug 27, 2024

Good catch @jsmithy2006 and @heap-s!

And thanks for the PR, it looks great! :)

Only one minor nitpick. Would it be possible for you to squash these 3 commits into a single commit? We like to try to keep the commit history clean and lean if we can. Let me know if you need any help with it!

@emtuls emtuls self-requested a review August 27, 2024 02:57
@emtuls emtuls added 🐛 bug Something isn't working 🌀 FLARE-VM A package or feature to be used by FLARE-VM labels Aug 27, 2024
Upddate version

Fix RLA not building

Fix ZimmermanTools Throwing 404
@heap-s
Copy link
Contributor Author

heap-s commented Aug 27, 2024

Hi @emtuls thanks a lot! Hopefully, I can continue to contribute in the future. I believe I did the squashing of the last 3 commits appropriately. Feel free to let me know if there is anything else that is needed for this to be merged.

@emtuls
Copy link
Member

emtuls commented Aug 27, 2024

@heap-s Looks great, thanks for doing that! Glad to have the extra help, we really appreciate it! 😊

@emtuls emtuls merged commit ac56103 into mandiant:main Aug 27, 2024
4 checks passed
@Ana06
Copy link
Member

Ana06 commented Aug 27, 2024

Thanks for the fix @heap-s! 🫶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🌀 FLARE-VM A package or feature to be used by FLARE-VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants