Update CyberChef to use CyberChef icon

[emtuls]

This converts the CyberChef PNG file that is provided with the download and converts it to a .ico so that Chocolatey can use it for an icon for the shortcut.

Closes #966

[Ana06]

Thanks for the changes @emtuls! After some more testing, I am not sure that converting the image to icon is the best approach. The current code make the shortcut looks like:

But we could download and use directly the icon in https://raw.githubusercontent.com/gchq/CyberChef/18159ce806e63286019a5a6828422a992fbb253b/src/web/static/images/favicon.ico which I think looks a bit better and removes the need for the extra code:

It is also confusing and inconsistent with other apps (like capa or fakenet) that the icon in the taskbar is a different one. This is related to #1021 and #822, but I think we should address then in the same PR so that the icon change takes place everywhere.

[Ana06]

@emtuls 👀

[emtuls]

@mandiant/flare-vm Any preference or thoughts on which icon to use for Cyberchef?
One icon uses the robot-chef mix. It looks good on taskbar and on the desktop but has a slight blurry look when viewed in the Tools folder in small/detail view.

The other icon is just a Chef hat (also provided by Cyberchef as a .ico, so not a random chef hat), which looks a little better in small/detail view, but I personally think it looks a bit blurry when viewed on Desktop and the Taskbar.

Another thing to note is that the Robot-Chef mix icon requires some additional code to convert an image file to a .ico file.

[Ana06]

@d35ha can you test this locally and share your opinion on this? 😄

[Ana06]

@stevemk14ebr @mr-tz @binjo @d35ha any preference on the icon? The icons look a bit different (see screenshots in the previous comments). @emtuls prefers to generate Robot-Chef icon (requires some additional code to convert an image file to a .ico file), while I prefer the Chef hat.

[stevemk14ebr]

I don't mind either, I vote for whichever is easiest to maintain

[mr-tz]

I don't mind either, I vote for whichever is easiest to maintain

I second this. FWIW taskbars may be configured in other colors (mine is black). I agree that gray on gray is a bit hard to see.

[Ana06]

I think the Chef hat is easier to maintain because it requires less code. But as it seems nobody else has a strong opinion, I'll let @emtuls decide. @emtuls can you please rebase the final version so that we can merge this change? 😄

[emtuls]

After googling CyberChef and seeing most websites/videos use the Robot-Chef icon, I'm inclined to keep that style for now. :)

[Ana06]

LGTM! 👍

I find it confusing to have the CyberChef icon in the taskbar and that when clicking it, it opens Chrome as a different taskbar icon:

But I think this is already part of #1100 and we can continue to discuss how to address it there.