lang: TR Language added #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mandaputtra
requested changes
Jun 8, 2022
api/[lang]/detail/index.ts
Outdated
| }); | ||
|
|
||
| const $ = cheerio.load(html); | ||
| //console.log("ss2", html); |
| }) | ||
| } | ||
|
|
||
| /* $("div.nutrient.black.right.tRight").each((_, elem: any) => { |
| console.log("normali", normalizeText); | ||
|
|
||
| switch (normalizeText) { | ||
| case "Enerji": |
There was a problem hiding this comment.
I think this detail is too specific with one language. Can you make it more language agnostic? Maybe add some parameters on utils/lang.ts. Just maybe add this types and update accordingly.
detailTextSeparator: {
energy: string;
protein: string;
fat: string
... etc
}
api/[lang]/detail/index.ts
Outdated
| const normalizeText = element.text().replace(/(\r\n|\n|\r\t|\t|\r)/gm, ""); | ||
| let item; | ||
| const nextELem = element.next().text(); | ||
| console.log("normali", normalizeText); |
There was a problem hiding this comment.
Please remove this console.log
api/[lang]/detail/index.ts
Outdated
| } | ||
|
|
||
| let _url = langConfig.baseUrl + detailUrl; | ||
| console.log("ss", _url); |
There was a problem hiding this comment.
Remove all console.log from code
|
Someone is attempting to deploy a commit to a Personal Account owned by @mandaputtra on Vercel. @mandaputtra first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.