add seq based roaming support for group #2549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
等 #2513 |
|
把这个也放到 rc 吧 |
|
发版之前写完就放 |
StageGuard
force-pushed
the
seq-based-roaming
branch
from
6a7c2ff
to
a3873b2
Compare
StageGuard
requested review from
Him188 and
Karlatemp
and removed request for
Him188
Karlatemp
reviewed
May 7, 2023
| * @see MessageSource | ||
| */ | ||
| public suspend fun getMessagesBefore( | ||
| messageId: Int? = null, |
There was a problem hiding this comment.
使用原始数据并不是一个好的做法，id 处理细节应该被隐藏, 用 MessageSource
而且用 messageId 不适合匹配别的 contact 实现
There was a problem hiding this comment.
我觉得 source 不好，就用 message id 就够了
source里面有的东西太多了，source还有sender 和 receiver， 传进去还得额外考虑这个的行为，得查它 sender 和 receiver 与这个 contact 相关，也得查 kind
Karlatemp
reviewed
May 7, 2023
| * @since 2.15 | ||
| * @see MessageSource | ||
| */ | ||
| public suspend fun getMessagesBefore( |
There was a problem hiding this comment.
Before 语义上是不包含给定的起始信息本身的, 我的想法是让这个方法返回的流中的返回包含给定的信息本身可能会更好
There was a problem hiding this comment.
可以都支持，把这个查询条件抽象出来，比如 Range.before/after/exact(id, inclusive = true), 还能加 after 与 in，自由更改参数，而不会增加和维护过多 getMessage “重载”，但这会一定程度增加复杂度，不过我感觉还好？
|
6, 这merge了个啥 |
Karlatemp
force-pushed
the
seq-based-roaming
branch
from
08041f3
to
575bac4
Compare
StageGuard
commented
Jul 26, 2023
| @@ -1056,17 +1056,19 @@ public final class net/mamoe/mirai/contact/roaming/RoamingMessageFilter$Companio | |||
|
|
|||
| public abstract interface class net/mamoe/mirai/contact/roaming/RoamingMessages { | |||
| public fun getAllMessages (Lnet/mamoe/mirai/contact/roaming/RoamingMessageFilter;)Lkotlinx/coroutines/flow/Flow; | |||
| public fun getAllMessages (Lnet/mamoe/mirai/contact/roaming/RoamingMessageFilter;Lkotlin/coroutines/Continuation;)Ljava/lang/Object; | |||
| public abstract fun getAllMessages (Lnet/mamoe/mirai/contact/roaming/RoamingMessageFilter;Lkotlin/coroutines/Continuation;)Ljava/lang/Object; | |||
| @@ -1056,17 +1056,19 @@ public final class net/mamoe/mirai/contact/roaming/RoamingMessageFilter$Companio | |||
|
|
|||
| public abstract interface class net/mamoe/mirai/contact/roaming/RoamingMessages { | |||
| public fun getAllMessages (Lnet/mamoe/mirai/contact/roaming/RoamingMessageFilter;)Lkotlinx/coroutines/flow/Flow; | |||
| public fun getAllMessages (Lnet/mamoe/mirai/contact/roaming/RoamingMessageFilter;Lkotlin/coroutines/Continuation;)Ljava/lang/Object; | |||
| public abstract fun getAllMessages (Lnet/mamoe/mirai/contact/roaming/RoamingMessageFilter;Lkotlin/coroutines/Continuation;)Ljava/lang/Object; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.