Feature/javascript changes #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update merge
Cleanups: - Reduced unneeded calls to set callbacks - tried to reduce amount of redundant code Fixes: - Ensure that all nodes and links have callbacks applied - Links are created with all properties - Stop graph animating while dragging edge Changes: - Newly created nodes are selected for editing - Slight refactor of reset() function to seperate concerns - Added boolean to try and stop occasional node creation when clicking on lines
- Add Node and Link objects to centralize drawing code - Add small system to detect changes and trigger paints - Generally make expanding code easier in the future - Move selection coloring into code as opposed to css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forked the project for my own purposes and cleaned up the JS a bit when learning how it worked.
Minor changes as listed in the commit comment but it makes the interface easier to use.