Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App share was deprecated in laravel 5.4. Using app singleton. #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

whoacowboy
Copy link

You master was off from the tag so I made a new branch, laravel5.4.

I changed one line of code because app->share was deprecated in 5.4 for app->singleton.


share Method Removed

The share method has been removed from the container. This was a legacy method that has not been documented in several years. If you are using this method, you should begin using the singleton method instead:

$container->singleton('foo', function () {
    return 'foo';
});

@hauthorn
Copy link

hauthorn commented Feb 18, 2017

This should be a priority. The fix takes few seconds to implement, but is indeed breaking.
I did the same change in our production app, and tests are passing again.

@AlexDanault
Copy link

I'm also waiting for this PR to be accepted, thanks !

@AlexDanault
Copy link

Guys, @maknz said on twitter that he doesn't have time to maintain this package anymore and will soon post a deprecation notice.

Link: https://twitter.com/maknz/status/833866298232754177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants