Timbo's Takeaway #2225
Open
Timbo's Takeaway #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmy-lyons
reviewed
May 3, 2022
| @order = [] | ||
| @order_total = 0 | ||
| @simp_order = "" | ||
|
|
There was a problem hiding this comment.
I'd put all the text stuff into its own class. I did have difficulties getting it to work from the order object, but my feeling was since it's a new noun, it should probably be its own class.
jimmy-lyons
reviewed
May 3, 2022
| "Your order so far is: #{simplify_order}" | ||
|
|
||
| end | ||
|
|
There was a problem hiding this comment.
I think this should be re-written so as not to be hard coded, but I like that you added a function that states the quantity of each item - that's not something I did.
jimmy-lyons
reviewed
May 3, 2022
| attr_reader :menu | ||
|
|
||
| def initialize | ||
|
|
There was a problem hiding this comment.
This could be re-written to import different menus, but I agree that a new menu instance should be initialised with a specific menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your name
Please write your full name here to make it easier to find your pull request.
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!