fix(result): Handle null additional_data in pagination_data #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where pagination_data would raise an error when additional_data is null. This patch addresses the problem by safely handling null values using dig. Additionally, test cases have been added to validate this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pagination_data method to handle null additional_data
This patch addresses an issue in the
pagination_datamethod withinresult.rbwhere an error occurred whenadditional_datawas null. The fix modifies the method to safely navigate through potentially null values using Ruby's dig method, ensuring robustness and preventing errors in such scenarios.Changes Made:
Updated
pagination_datamethod inresult.rbto safely accessadditional_datausingdig.Added test cases in
result_spec.rbto validate behavior for both present and nulladditional_data.Test Coverage:
Introduced new tests to cover scenarios where
additional_datais both present and null.Ensured that
pagination_datacorrectly returns expected results or an empty hash whenadditional_datais null.This change enhances the reliability of the
pagination_datamethod, ensuring consistent behavior across various input conditions.