Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup chitter #209

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

setup chitter #209

wants to merge 2 commits into from

Conversation

PeterHattyar
Copy link

No description provided.

siellsiell
siellsiell reviewed Apr 7, 2022
View reviewed changes
Copy link
Contributor

@siellsiell siellsiell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

I'm Simo, a coach. Thanks for submitting your code! This is a good start at the challenge. If you encountered blockers along the way, do reach out to your coach so that they can support.

app.rb
Comment on lines 5 to 7
get '/test' do
'Test page'
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good practice to remove test code before submitting code for review (anywhere, not just at Makers)

spec/features/test_page_spec.rb

expect(page).to have_content "Welcome to Chitter!"
expect(page).to have_content "test-peep"
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siellsiell siellsiell siellsiell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterHattyar @siellsiell