Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airport Challenge Stevie Spiegl #2510

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

S-Spiegl
Copy link

@S-Spiegl S-Spiegl commented Apr 24, 2022

Your name

Steven Spiegl

User stories

Please list which user stories you've implemented (delete the ones that don't apply).

  • [ x ] User story 1: "I want to instruct a plane to land at an airport"
  • User story 2: "I want to instruct a plane to take off from an airport and confirm that it is no longer in the airport"
  • User story 3: "I want to prevent landing when the airport is full"
  • User story 4: "I would like a default airport capacity that can be overridden as appropriate"
  • User story 5: "I want to prevent takeoff when weather is stormy"
  • User story 6: "I want to prevent landing when weather is stormy"

README checklist

Does your README contains instructions for

  • how to install,
  • how to run,
  • and how to test your code?

Here is a pill that can help you write a great README!

@S-Spiegl
Copy link
Author

Line 15 should read: land and fly those planes e.g. heathrow.land_plane(boeing_747)

@planes << plane
end

attr_accessor :planes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the ruby convention is to use attr_reader over attr_accessor, and that they go before the methods in the class

Copy link

@SamButton12 SamButton12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants