Archie Martin Airport Challenge #2507
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 24, 2022 14:30
…t up classes, and planes can exist in two places at once...sorry for not committing enough :(
…ests will pass regarding anything to do with landing/taking_off. I'm done for tonight.
K-Carty
reviewed
Apr 25, 2022
| @@ -0,0 +1,103 @@ | |||
| require 'airport.rb' | |||
There was a problem hiding this comment.
In general, I appreciate your use of Single Responsibility Principle. It make the code super readable with names that makes sense.
| expect(port.send(:full?)).to eq false | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
Good that you described the method within the class before testing it.
| end | ||
|
|
||
| describe Plane do | ||
|
|
There was a problem hiding this comment.
Perhaps you could have used a separate new doc and spec_helper for the Plane class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your name
Archie Martin
Please write your full name here to make it easier to find your pull request.
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!