Coral airport_challenge #2494
Coral airport_challenge #2494
Conversation
| take_off_checks(plane) | ||
| @hangar.delete(plane) | ||
| end | ||
|
|
There was a problem hiding this comment.
The use of private methods really helps with isolating parts of the code that you don't want the user to access.
There was a problem hiding this comment.
This also greatly simplifies the code that the user will be using
| let(:plane) { double :plane } | ||
| let(:plane2) { double :plane2 } | ||
| let(:airport) { Airport.new(5) } | ||
|
|
There was a problem hiding this comment.
Tests have been ordered well with landing tests grouped together first before take off tests
|
|
||
| describe Airport do | ||
| let(:plane) { double :plane } | ||
| let(:plane2) { double :plane2 } |
There was a problem hiding this comment.
Use single line syntax for setting doubles with their own methods and return values in each unit test to make code more DRY
There was a problem hiding this comment.
Can also take that a step further by using a "before do" bock of code to set the doubles and method results for all subsequent tests
| @capacity = capacity | ||
| @weather = Weather.new | ||
| end | ||
|
|
There was a problem hiding this comment.
Methods were kept very short which makes them easier to understand
|
|
||
| it 'returns true if theres a storm.' do | ||
| expect(subject.storm?).to be(true).or be(false) | ||
| end |
There was a problem hiding this comment.
Use "srand" to remove the random number generation and set the weather to what you want in the test
Coral Baker
Please write your full name here to make it easier to find your pull request.
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!