Skip to content

Commit

Permalink
Merge pull request #688 from jmrenouard/master
Browse files Browse the repository at this point in the history
Version 2.2.0 issues #686
  • Loading branch information
jmrenouard committed Jun 26, 2023
2 parents 46f0aea + b008591 commit 9bf2c04
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 10 deletions.
40 changes: 32 additions & 8 deletions mysqltuner.pl
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env perl
# mysqltuner.pl - Version 2.2.0
# mysqltuner.pl - Version 2.2.1
# High Performance MySQL Tuning Script
# Copyright (C) 2006-2023 Major Hayden - [email protected]
# Copyright (C) 2015-2023 Jean-Marie Renouard - [email protected]
Expand Down Expand Up @@ -57,7 +57,7 @@ package main;
#use Env;

# Set up a few variables for use in the script
my $tunerversion = "2.2.0";
my $tunerversion = "2.2.1";
my ( @adjvars, @generalrec );

# Set defaults
Expand All @@ -69,8 +69,8 @@ package main;
"debug" => 0,
"nocolor" => ( !-t STDOUT ),
"color" => 0,
"forcemem" => 1024,
"forceswap" => 1024,
"forcemem" => 0,
"forceswap" => 0,
"host" => 0,
"socket" => 0,
"port" => 0,
Expand Down Expand Up @@ -811,7 +811,15 @@ sub mysql_setup {
# If we're doing a remote connection, but forcemem wasn't specified, we need to exit
if ( $opt{'forcemem'} eq 0 && is_remote eq 1 ) {
badprint "The --forcemem option is required for remote connections";
exit 1;
badprint "Assuming RAM memory is 1Gb for simplify remote connection usage";
$opt{'forcemem'} = 1024;
#exit 1;
}
if ( $opt{'forceswap'} eq 0 && is_remote eq 1 ) {
badprint "The --forceswap option is required for remote connections";
badprint "Assuming Swap size is 1Gb for simplify remote connection usage";
$opt{'forceswap'} = 1024;
#exit 1;
}
infoprint "Performing tests on $opt{host}:$opt{port}";
$remotestring = " -h $opt{host} -P $opt{port}";
Expand Down Expand Up @@ -1974,9 +1982,26 @@ sub system_recommendations {
return;
}
prettyprint "Look for related Linux system recommendations";

#prettyprint '-'x78;
get_system_info();


my $nb_cpus = cpu_cores;
if ($nb_cpus > 1) {
goodprint "There is at least one CPU dedicated to database server.";
} else {
badprint "There is only one CPU, consider dedicated one CPU for your database server";
push @generalrec, "Consider increasing number of CPU for your database server";
}

if ($physical_memory < 1600) {
goodprint "There is at least 1 Gb of RAM dedicated to Linux server.";
} else {
badprint "There is less than 1,5 Gb of RAM, consider dedicated 1 Gb for your Linux server";
push @generalrec, "Consider increasing 1,5 / 2 Gb of RAM for your Linux server";
}

my $omem = get_other_process_memory;
infoprint "User process except mysqld used "
. hr_bytes_rnd($omem) . " RAM.";
Expand Down Expand Up @@ -5808,7 +5833,6 @@ sub mysql_table_structures {
);
$tmpContent='Schema,Table,Column, Charset, Collation, Data Type, Max Length';
foreach my $badtable (@utf8columns) {
badprint "\t$badtable";
$tmpContent.="\n$badtable";
}
dump_into_file( "columns_utf8.csv", $tmpContent );
Expand Down Expand Up @@ -7225,7 +7249,7 @@ sub which {
=head1 NAME
MySQLTuner 2.2.0 - MySQL High Performance Tuning Script
MySQLTuner 2.2.1 - MySQL High Performance Tuning Script
=head1 IMPORTANT USAGE GUIDELINES
Expand Down
8 changes: 6 additions & 2 deletions renovate.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"extends": [
"config:base"
]
}
],
"git-submodules": {
"enabled": true
},
"dependencyDashboard": true
}

0 comments on commit 9bf2c04

Please sign in to comment.