fix: error compare

maistra · Sep 4, 2024 · c8de23b · c8de23b
1 parent 27b984e
commit c8de23b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/controllers/routingctrl/delete_resources.go b/controllers/routingctrl/delete_resources.go
@@ -32,12 +32,12 @@ func (r *Controller) removeUnusedRoutingResources(ctx context.Context, target *u
 func (r *Controller) handleResourceDeletion(ctx context.Context, sourceRes *unstructured.Unstructured) error {
 	exportModes := r.extractExportModes(sourceRes)
 	if len(exportModes) == 0 {
-		r.log.Info("No export modes found, skipping deletion logic", "sourceRes", sourceRes)
+		r.log.Info("no export modes found, skipping deletion logic", "sourceRes", sourceRes)
 
 		return nil
 	}
 
-	r.log.Info("Handling deletion of dependent resources", "sourceRes", sourceRes)
+	r.log.Info("handling deletion of dependent resources", "sourceRes", sourceRes)
 
 	gvks := routingResourceGVKs(exportModes...)
 

diff --git a/controllers/routingctrl/exported_svc_locator.go b/controllers/routingctrl/exported_svc_locator.go
@@ -48,6 +48,11 @@ func (e *ExportedServiceNotFoundError) Error() string {
 	return fmt.Sprintf("no exported services found for target %s/%s (%s)", e.target.GetNamespace(), e.target.GetName(), e.target.GetObjectKind().GroupVersionKind().String())
 }
 
+func (e *ExportedServiceNotFoundError) Is(target error) bool {
+	_, ok := target.(*ExportedServiceNotFoundError)
+	return ok
+}
+
 func isExportedServiceNotFoundError(err error) bool {
 	return errors.Is(err, &ExportedServiceNotFoundError{})
 }
diff --git a/controllers/routingctrl/reconcile_resources.go b/controllers/routingctrl/reconcile_resources.go
@@ -27,7 +27,7 @@ func (r *Controller) createRoutingResources(ctx context.Context, target *unstruc
 		return r.propagateHostsToWatchedCR(ctx, target, nil, nil)
 	}
 
-	r.log.Info("Reconciling resources for target", "target", target)
+	r.log.Info("reconciling resources for target", "target", target)
 
 	renderedSelectors, errLables := config.ResolveSelectors(r.component.ServiceSelector, target)
 	if errLables != nil {