Don't cache false responses.

mailgun · Dec 15, 2014 · e5da460 · e5da460
1 parent 788d773
commit e5da460
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/flanker/addresslib/validate.py b/flanker/addresslib/validate.py
@@ -138,15 +138,17 @@ def mail_exchanger_lookup(domain, metrics=False):
         mx_hosts = lookup_domain(domain)
         mtimes['dns_lookup'] += time.time() - bstart
         if mx_hosts is None:
-            mx_cache[domain] = False
+            #commenting out falses in the cache, be sure to monitor backend load. - Jason
+            #mx_cache[domain] = False
             return None, mtimes
 
     # test connecting to the mx exchanger
     bstart = time.time()
     mail_exchanger = connect_to_mail_exchanger(mx_hosts)
     mtimes['mx_conn'] = time.time() - bstart
     if mail_exchanger is None:
-        mx_cache[domain] = False
+        #commenting out falses in the cache, be sure to monitor backend load. - Jason
+        #mx_cache[domain] = False
         return None, mtimes
 
     # valid mx records, connected to mail exchanger, return True

diff --git a/setup.py b/setup.py
@@ -5,7 +5,7 @@
 
 
 setup(name='flanker',
-      version='0.3.24',
+      version='0.3.25',
       description='Mailgun Parsing Tools',
       long_description=open('README.rst').read(),
       classifiers=[],