Merge pull request #66 from mailgun/jeremy/charset

don't default to ascii charset for non-text Content-Types

flanker/mime/message/headers/wrappers.py

@@ -100,7 +100,11 @@ def get_boundary_line(self, final=False):
             self.get_boundary(), "--" if final else "")
 
     def get_charset(self):
-        return self.params.get("charset", 'ascii').lower()
+        default = 'ascii' if self.main == 'text' else None
+        c = self.params.get("charset", default)
+        if c:
+            c = c.lower()
+        return c
 
     def set_charset(self, value):
         self.params["charset"] = value.lower()

setup.py

@@ -5,7 +5,7 @@
 
 
 setup(name='flanker',
-      version='0.4.21',
+      version='0.4.22',
       description='Mailgun Parsing Tools',
       long_description=open('README.rst').read(),
       classifiers=[],

tests/mime/message/headers/wrappers_test.py

@@ -0,0 +1,10 @@
+from nose.tools import eq_
+
+from flanker.mime.message.headers.wrappers import ContentType
+
+def charset_test():
+    c = ContentType('text', 'plain')
+    eq_('ascii', c.get_charset())
+
+    c = ContentType('application', 'pdf')
+    eq_(None, c.get_charset())