Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tvOS framework target for Carthage support on tvOS #1174

Closed
wants to merge 2 commits into from

Conversation

Jeehut
Copy link

@Jeehut Jeehut commented Jan 23, 2016

This adds basic tvOS framework support via Carthage. Note that I also unified the two identical files MagicalRecordTests-iOS-Info.plist and MagicalRecordTests-OSX-Info.plist files into one to prevent redundancy and adding even a third one for tvOS.

It doesn't compile yet though due to some deprecated features that aren't available from iOS 9+ / tvOS 9+. Those issues are already dealt with in separate branches / issues / pull requests, so I think this can be merged first.

Specifically the following will help fixing the compilation issues for the tvOS target:

pull-requests: #1163, #1164
issue: #1143
branch: fix/3.0-concurrency-debug

@Coeur
Copy link
Collaborator

Coeur commented May 31, 2019

#1163 will not be merged anytime soon.
I'm not going to merge a target that doesn't build: such target could live on its own tvOS branch, but not a branch used for releases. See https://github.com/Coeur/MagicalRecord/tree/tvos for instance.

Good idea about about merging the plist... but the content is small, and there may be a day with future keys that are only meaningful for one platform and not another, like UIRequiredDeviceCapabilities.

Thank you nonetheless. I'll see if I can add tvOS support soon (I mean on the 2.3.x / master branch), or if I give up on the idea. For the 3.0 branch, it'll have to wait until I merge master into it.

@Coeur Coeur closed this May 31, 2019
@Coeur
Copy link
Collaborator

Coeur commented Jun 4, 2019

Oh well, Xcode 11 changelog:

Xcode removes some entries from the Info.plist file of a product at build time if the entries are not appropriate for the platform being built for, which is useful for targets which are configured to build for multiple platforms. This behavior can be disabled by setting the build setting DISABLE_INFOPLIST_PLATFORM_PROCESSING to YES, in which case the target must assume the responsibility of managing these entries appropriately. (47797497)

Which means that having the same plist is now fine.

@Coeur
Copy link
Collaborator

Coeur commented Jun 20, 2019

tvOS support added on master with #1362.

@Jeehut
Copy link
Author

Jeehut commented Jun 21, 2019

Thanks, @Coeur! Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants