Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking nullability of test properties before setting to null in integration test framework cleanup #39232

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

stollr
Copy link
Contributor

@stollr stollr commented Oct 2, 2024

Description (*)

Previously an error occured if a non-nullable typed property was used in a test case. The error message was something like

Cannot assign null to property MyVendor\MyModule\Test\Integration\MyTest::$objectManager of type Magento\Framework\ObjectManagerInterface

Manual testing scenarios (*)

  1. Add a non-nullable typed property to an integration test (like the one in the DummyTestCase in this PR)
  2. Run the test
  3. In the test result there will occur an error message looking like the above one.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Checking nullability of test properties before setting to null in integration test framework cleanup #39245: Checking nullability of test properties before setting to null in integration test framework cleanup

Copy link

m2-assistant bot commented Oct 2, 2024

Hi @stollr. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Hotel engcom-Hotel added Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Oct 8, 2024
@engcom-Hotel
Copy link
Contributor

@magento create issue

…egration test framework cleanup

Previously an error occured if a non-nullable typed property was used in a test case. The error message was something like

> Cannot assign null to property MyVendor\MyModule\Test\Integration\MyTest::$objectManager of type Magento\Framework\ObjectManagerInterface
@stollr stollr force-pushed the handle_non-nullable_props_in_tests branch from aba5413 to 821c0f6 Compare October 9, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Checking nullability of test properties before setting to null in integration test framework cleanup
2 participants