Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Lighthouse scan to reach 100% Accessibility on Homepage #39164

Open
wants to merge 6 commits into
base: 2.4-develop
Choose a base branch
from
Open

Allow Lighthouse scan to reach 100% Accessibility on Homepage #39164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f7aa872
Improve accesibility on the sections
Serfe-com Sep 12, 2024
1a2c165
Improved color contrast
Serfe-com Sep 12, 2024
09b3253
Merge branch '2.4-develop' into accesibility-improvements
Serfe-com Sep 12, 2024
2ef6ad7
Update _module.less
Serfe-com Sep 17, 2024
d003fd2
Merge branch 'magento:2.4-develop' into accesibility-improvements
Serfe-com Sep 17, 2024
10e3f16
Merge branch 'magento:2.4-develop' into accesibility-improvements
Serfe-com Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions app/code/Magento/Theme/view/frontend/templates/html/sections.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,15 @@
/**
* General template for displaying group of blocks divided into sections
*/
/** @var \Magento\Framework\Escaper $escaper */

$group = $block->getGroupName();
$groupCss = $block->getGroupCss();
?>
<?php if ($detailedInfoGroup = $block->getGroupChildNames($group)):?>
<div class="sections <?= $block->escapeHtmlAttr($groupCss) ?>">
<div class="sections <?= $escaper->escapeHtmlAttr($groupCss) ?>">
<?php $layout = $block->getLayout(); ?>
<div class="section-items <?= $block->escapeHtmlAttr($groupCss) ?>-items"
<div class="section-items <?= $escaper->escapeHtmlAttr($groupCss) ?>-items"
data-mage-init='{"tabs":{"openedState":"active"}}'>
<?php foreach ($detailedInfoGroup as $name):?>
<?php
Expand All @@ -25,19 +26,19 @@ $groupCss = $block->getGroupCss();
$alias = $layout->getElementAlias($name);
$label = $block->getChildData($alias, 'title');
?>
<div class="section-item-title <?= $block->escapeHtmlAttr($groupCss) ?>-item-title"
<div class="section-item-title <?= $escaper->escapeHtmlAttr($groupCss) ?>-item-title"
data-role="collapsible">
<a class="<?= $block->escapeHtmlAttr($groupCss) ?>-item-switch"
data-toggle="switch" href="#<?= $block->escapeHtmlAttr($alias) ?>">
<a class="<?= $escaper->escapeHtmlAttr($groupCss) ?>-item-switch"
data-toggle="switch" href="#<?= $escaper->escapeHtmlAttr($alias) ?>">
<?= /* @noEscape */ $label ?>
</a>
</div>
<div class="section-item-content <?= $block->escapeHtmlAttr($groupCss) ?>-item-content"
id="<?= $block->escapeHtmlAttr($alias) ?>"
data-role="content">
<div class="section-item-content <?= $escaper->escapeHtmlAttr($groupCss) ?>-item-content"
id="<?= $escaper->escapeHtmlAttr($alias) ?>"
role="tab">
<?= /* @noEscape */ $html ?>
</div>
<?php endforeach;?>
</div>
</div>
<?php endif; ?>
<?php endif; ?>
6 changes: 3 additions & 3 deletions app/design/frontend/Magento/blank/Magento_Swatches/web/css/source/_module.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

// Size and Manufacturer attributes
@attr-swatch-option__background: @swatch-option__background;
@attr-swatch-option__color: #949494;
@attr-swatch-option__color: #474747;

@attr-swatch-option__selected__background: @color-white;
@attr-swatch-option__selected__border: @border-width__base solid @color-white;
Expand All @@ -47,7 +47,7 @@
// Tooltip
@swatch-option-tooltip__background: @color-white;
@swatch-option-tooltip__border: @swatch-option__border;
@swatch-option-tooltip__color: #949494;
@swatch-option-tooltip__color: #474747;

@swatch-option-tooltip-title__color: #282828;

Expand Down Expand Up @@ -184,7 +184,7 @@
pointer-events: none;

&:after {
// ToDo: improve .lib-background-gradient() to support diagonal gradient
// ToDo: improve .lib-background-gradient() to support diagonal gradient;
background: linear-gradient(to left top, rgba(255, 255, 255, 0) 0%, rgba(255, 255, 255, 0) 42%, rgba(255, 255, 255, 1) 43%, rgba(255, 255, 255, 1) 46%, rgba(255, 82, 22, 1) 47%, rgba(255, 82, 22, 1) 53%, rgba(255, 255, 255, 1) 54%, rgba(255, 255, 255, 1) 57%, rgba(255, 255, 255, 0) 58%, rgba(255, 255, 255, 0) 100%);
background: -moz-linear-gradient(to left top, rgba(255, 255, 255, 0) 0%, rgba(255, 255, 255, 0) 42%, rgba(255, 255, 255, 1) 43%, rgba(255, 255, 255, 1) 46%, rgba(255, 82, 22, 1) 47%, rgba(255, 82, 22, 1) 53%, rgba(255, 255, 255, 1) 54%, rgba(255, 255, 255, 1) 57%, rgba(255, 255, 255, 0) 58%, rgba(255, 255, 255, 0) 100%);
background: -ms-linear-gradient(to left top, rgba(255, 255, 255, 0) 0%, rgba(255, 255, 255, 0) 42%, rgba(255, 255, 255, 1) 43%, rgba(255, 255, 255, 1) 46%, rgba(255, 82, 22, 1) 47%, rgba(255, 82, 22, 1) 53%, rgba(255, 255, 255, 1) 54%, rgba(255, 255, 255, 1) 57%, rgba(255, 255, 255, 0) 58%, rgba(255, 255, 255, 0) 100%);
Expand Down