Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add paypal_express_visible_on_cart & paypal_express_active in graphql StoreConfig #39163

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

dimitriBouteille
Copy link

@dimitriBouteille dimitriBouteille commented Sep 12, 2024

Description (*)

This PR add paypal_express_visible_on_cart and paypal_express_active in graphQl StoreConfig type.

👍 I think, is important to prefix configuration by theme (ie: paypal) - So payment_payflowpro_cc_vault_active must be replaced by paypal_payment_payflowpro_cc_vault_active ...

query StoreConfig {
  storeConfig {
    paypal_express_active
    paypal_express_visible_on_cart
  }
}

Related Pull Requests

None

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

Setup PayPal and execute following graphql query :

query StoreConfig {
  storeConfig {
    paypal_express_active
    paypal_express_visible_on_cart
  }
}

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] [Feature request] Add paypal_express_visible_on_cart & paypal_express_active in graphql StoreConfig #39165: [Feature request] Add paypal_express_visible_on_cart & paypal_express_active in graphql StoreConfig

Copy link

m2-assistant bot commented Sep 12, 2024

Hi @dimitriBouteille. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@dimitriBouteille
Copy link
Author

@magento run all tests

@dimitriBouteille dimitriBouteille changed the title Add paypal_express_visible_on_cart & paypal_express_active in graphql StoreConfig [Feature request] Add paypal_express_visible_on_cart & paypal_express_active in graphql StoreConfig Sep 12, 2024
@engcom-Hotel
Copy link
Contributor

@magento create issue

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 12, 2024
@Den4ik
Copy link
Contributor

Den4ik commented Sep 18, 2024

@dimitriBouteille Please sign CLA

@Den4ik Den4ik self-requested a review September 18, 2024 07:00
@dimitriBouteille
Copy link
Author

@Den4ik Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] [Feature request] Add paypal_express_visible_on_cart & paypal_express_active in graphql StoreConfig
3 participants