Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks array key is defined before updating bookmarks #39143

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

NetStorm84
Copy link
Contributor

Description (*)

This fixes an error when if a certain admin grid does not have filters then an error was being shown and changes to the grid were not saved, such as moving a column position.. This PR checks to see if certain array keys are set before doing a comparison on them.

image

Fixed Issues (if relevant)

  1. Fixes Error on adminhtml popup product grids (e.g. adding Simple Product to Grouped Product) #38778

Manual testing scenarios (*)

Go to a grid that doesn't have filters and change the columns sort order by dragging a column to a new position

Copy link

m2-assistant bot commented Sep 5, 2024

Hi @NetStorm84. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 5, 2024
@NetStorm84
Copy link
Contributor Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on adminhtml popup product grids (e.g. adding Simple Product to Grouped Product)
1 participant