Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Approach to Implementation

Vladyslav Podorozhnyi edited this page May 6, 2019 · 4 revisions

Assumptions

  1. Builds on 2.3-develop branch are green at any given time

Branching

  1. Create branches in current repository and make pull requests from these branches. Do not use forks. This will simplify collaboration on the same features between independent contributors and Magento team members

Technical requirements to features

  1. All implemented features MUST follow:
  2. All builds for the PR MUST be green
    • Travis CI - visible for the community
    • Internal Magento builds - results provided by the Magento team, if there are any issues
  3. GraphQL implementation must not require changes to non-GraphQL modules, except for addition of missing extension points
  4. GraphQL should be fully modular and Magento should function properly with or without it

Backward compatibility policy

  • For GraphQl project - only schema can be counted as a contract;
  • Only schema should be taken into account for backward compatibility needs;
  • GraphQl PHP codebase should not follow Backward compatible development guide;