Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache to the BlockifierStateAdapter for setters #43

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Add cache to the BlockifierStateAdapter for setters #43

merged 3 commits into from
Apr 9, 2024

Conversation

jbcaron
Copy link
Member

@jbcaron jbcaron commented Apr 8, 2024 •
edited
Loading

Pull Request type

  • Feature

What is the current behavior?

  • each State implementation method of BlockifierStateAdapter mutates the local database

What is the new behavior?

  • each set of BlockifierStateAdapter is stored locally in the cache of the BlockifierStateAdapter instance
  • the getters of BlockifierStateAdapter use the cache as a priority if there have already been changes and otherwise search in the DB
  • removed code for transaction execution for Madara

Does this introduce a breaking change?

Other information

@jbcaron jbcaron marked this pull request as ready for review April 8, 2024 22:25
@antiyro antiyro merged commit bfd3c3f into madara-alliance:feat/up_blockifier Apr 9, 2024
@jbcaron jbcaron self-assigned this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiyro antiyro antiyro approved these changes

@Trantorian1 Trantorian1 Awaiting requested review from Trantorian1

Assignees

@jbcaron jbcaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbcaron @antiyro