Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api_key): Added support for --gateway-api to avoid rate limit from the gateway #30

Merged
merged 2 commits into from
Mar 28, 2024
Merged

feat(api_key): Added support for --gateway-api to avoid rate limit from the gateway #30

merged 2 commits into from
Mar 28, 2024

Conversation

antiyro
Copy link
Member

@antiyro antiyro commented Mar 28, 2024

feat(api_key): Added support for --gateway-api to avoid rate limit from the gateway

jbcaron
jbcaron approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@jbcaron jbcaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything seems correct, an interesting feature would be to retrieve the key via an environment variable with std::env

@antiyro
Copy link
Member Author

antiyro commented Mar 28, 2024

everything seems correct, an interesting feature would be to retrieve the key via an environment variable with std::env

Agree we should add a config file in general for parameters

@antiyro antiyro merged commit b696ca7 into main Mar 28, 2024
6 checks passed
@antiyro antiyro deleted the feat/gateway_key branch March 29, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbcaron jbcaron jbcaron approved these changes

@Tbelleng Tbelleng Tbelleng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antiyro @jbcaron @Tbelleng