Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase latest blockifier version 🔀 #27

Merged
merged 160 commits into from
Apr 10, 2024
Merged

Rebase latest blockifier version 🔀 #27

merged 160 commits into from
Apr 10, 2024

Conversation

Tbelleng
Copy link
Contributor

Pull Request type

  • Feature

What is the current behavior?

This PR aim to rebase Deoxys on the latest blockifier version 🆙.
its change several type and function, mainly accros the primitive crate

What is the new behavior?

Deoxys will use last blockifier version.

Does this introduce a breaking change?

Other information

Tbelleng and others added 23 commits March 27, 2024 13:00
@Tbelleng
feat: 🎨 fmt
0b53a77
@Tbelleng
feat: 🔥 few errors lefts
a3e12b8
@Tbelleng
feat: ✅ solving convert
39cdd00
@Tbelleng
feat: ✅ modifying lot of rpc type into the runtime (we have to replac…
7f7e5d8 
…e them into rpc methods too)
@Tbelleng
feat: 🎨 fmt
85d6915
@Tbelleng
feat: ✅ Block primitives done
84c8723
@Tbelleng
feat: 🚧 Working on starknet pallet
e3ad767
@jbcaron
feat: 🚧 utils rpc
96e11da
@Tbelleng
feat: 🐛 genesis_loader and simulation to fix
3c83d3b
@Tbelleng
Merge branch 'feat/up_blockifier' of https://github.com/KasarLabs/deoxys
3b880ef 
 into feat/up_blockifier
@Tbelleng
feat: 🐛 fixing GenesisData
4fcffd0
@Tbelleng
feat: 🐛 genesis loader fixed
71f2825
@jbcaron
feat: 🚧 use blockifier AccountTransaction for simulation and re_exe…
c1a3c3a 
…cution
@Tbelleng
feat: 🐛 pallets.rs fixed
2faacea
@Tbelleng
feat: ✅ runtime crate done
fd2a38a
@Tbelleng
feat: 🎨 fmt
d6aabbd
@jbcaron
feat: 🚧 change proto for simulate and re_execute_transaction
b3e4346
@jbcaron
revert: ⏪ revert changes about block_header
41af674
@jbcaron
feat: 🚧 start the conversion from starknet-rs tx to blockifier tx
c6fd15a
@antiyro
rebased starknet rs
ecc90c0
@Tbelleng
sync
75293d6
@Tbelleng
Merge branch 'feat/up_blockifier' of https://github.com/KasarLabs/deoxys
270c338 
 into feat/up_blockifier
@antiyro
cleaning declares
4b6e3e7
Trantorian1
Trantorian1 reviewed Apr 9, 2024
View reviewed changes
crates/client/mapping-sync/src/sync_blocks.rs Show resolved Hide resolved
crates/client/rpc/src/madara_backend_client.rs Show resolved Hide resolved
crates/client/rpc/src/methods/get_block.rs Outdated Show resolved Hide resolved
crates/client/rpc/src/methods/read/estimate_fee.rs Show resolved Hide resolved
crates/client/rpc/src/methods/read/estimate_message_fee.rs Outdated Show resolved Hide resolved
crates/primitives/transactions/src/compute_hash.rs Show resolved Hide resolved
crates/primitives/transactions/src/compute_hash.rs Outdated Show resolved Hide resolved
crates/primitives/transactions/src/from_broadcasted_transactions.rs Show resolved Hide resolved
crates/primitives/transactions/src/getters.rs Show resolved Hide resolved
crates/primitives/transactions/src/to_starknet_core_transaction.rs Show resolved Hide resolved
@jbcaron
Copy link
Member

jbcaron commented Apr 10, 2024 •
edited by antiyro
Loading

TODO:

  • group the utils methods of tx_recipt andcrates/client/rpc/src/methods/trace/utils.rs and crates/client/rpc/src/methods/trace/trace_block_transactions.rs
  • fix declare transaction transformation (starknet_api -> blockifier) in get_transaction_receipt()
  • implement data_gasin tx_execution_infos_to_simulated_transactions()
  • return real excution_info in crates/client/rpc/src/methods/trace/utils.rs

@jbcaron jbcaron added the help wanted Extra attention is needed label Apr 10, 2024
@jbcaron jbcaron self-requested a review April 10, 2024 15:03
jbcaron
jbcaron approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@jbcaron jbcaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave you the pleasure of merge boss

@antiyro antiyro merged commit 15e121c into main Apr 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trantorian1 Trantorian1 Trantorian1 left review comments

@noamoulin noamoulin noamoulin left review comments

@jbcaron jbcaron jbcaron approved these changes

@antiyro antiyro antiyro approved these changes

Assignees

@jbcaron jbcaron

@Tbelleng Tbelleng

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tbelleng @jbcaron @noamoulin @antiyro @Trantorian1