refactor: calculate class hash in devnet #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbcaron
reviewed
Sep 18, 2024
| @@ -24,11 +26,23 @@ pub enum InitiallyDeclaredClass { | |||
| } | |||
|
|
|||
| impl InitiallyDeclaredClass { | |||
There was a problem hiding this comment.
just out of curiosity, why aren’t the classes definition stored compressed directly?
There was a problem hiding this comment.
I didn't understand the question sorry, the compressed version is stored now right?
There was a problem hiding this comment.
it's just that we produce uncompressed class definitions with scarb
There was a problem hiding this comment.
Oh ok, I am not really sure but if Scarb has that option then this could be an optimisation, yes.
|
lgtm have you tested it with different scarb versions? |
Yes! |
antiyro
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current setup, the class hashes for devnet are hard coded. This isn't really a big issue but everytime we update the Cairo compiler we need to manually change these class hashes in the devnet. This PR calculates the class hash instead of taking the hardcoded values.