fix: flaky test #262
Merged
fix: flaky test #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 17, 2024 14:21
Mohiiit
requested review from
antiyro,
apoorvsadana and
ocdbytes
and removed request for
apoorvsadana
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were flaky tests in gas price worker because of the anvil instance, now each test has it's own anvil instance, it's not super beautiful but it works :) and it's stable (I hope)
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
In current case we launch an anvil instance and this is shared among tests. Because of the rust lifetimes, sometimes the anvil instance get out of scope before each test runs.
This was adopted because it was a code repetition.
Resolves: #NA
What is the new behavior?
Does this introduce a breaking change?
No