feat: add coveralls to ci #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiyro
reviewed
Sep 11, 2024
Coverage reportThe coverage rate is
|
|
Actually I would take this PR to replace the comment from github actions with one from coveralls wdyt? |
done |
EvolveArt
force-pushed
the
feat/better-ci
branch
from
3bf36c9
to
c78d867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
X Other (please describe): CI
What is the current behavior?
Resolves: #NA
What is the new behavior?
Does this introduce a breaking change?
No
Other information
It was investigated to check number of unwraps but it doesn't make any sense to do in rust, it's fine to just make sure by ourselves there are no unsafe unwraps. We can always come back and add it where most unsafe ones have been removed.
As for the criterion benchmarking it should come in a separate PR as we first need to precisely know what should be benchmarked.