Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable chain config #255

Merged

Conversation

azurwastaken
Copy link
Contributor

Pull Request type

  • Feature

What is the current behavior?

Resolves: #240

What is the new behavior?

  • We can now provide a yaml with chain config description or use presets to populate chain config struct

Does this introduce a breaking change?

No

Other information

@antiyro antiyro added the enhancement New feature or request label Sep 10, 2024
@azurwastaken azurwastaken marked this pull request as ready for review September 12, 2024 09:11
@EvolveArt EvolveArt changed the title Feat/configurable chain config feat: configurable chain config Sep 12, 2024
@@ -0,0 +1,33 @@
chain_name: "Starknet Mainnet"
Copy link
Member

@antiyro antiyro Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you drop some documentation describing each of these fields?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@Trantorian1 Trantorian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems good. Check comments for a few changes to change, maily refactoring.

crates/client/eth/src/l1_messaging.rs Outdated Show resolved Hide resolved
crates/node/src/cli/chain_config_overrides.rs Outdated Show resolved Hide resolved
crates/node/src/cli/mod.rs Show resolved Hide resolved
Copy link
Collaborator

@Trantorian1 Trantorian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

@EvolveArt EvolveArt merged commit 8be242a into madara-alliance:main Sep 18, 2024
8 checks passed
@EvolveArt EvolveArt deleted the feat/configurable-chain-config branch September 18, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Configurable chain config (duh)
4 participants