Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding the --starting-from arg back by ignoring ordered state #245

Merged
merged 11 commits into from
Sep 11, 2024

Conversation

antiyro
Copy link
Member

@antiyro antiyro commented Sep 5, 2024

fixing an error happening when syncinc closed blocks when syncing pendings that makes the node crash in full mode

adding the --starting-from arg back by ignoring ordered state

@antiyro antiyro added the full node Full Node only related issues label Sep 6, 2024
@antiyro antiyro self-assigned this Sep 6, 2024
@antiyro antiyro marked this pull request as ready for review September 9, 2024 13:52
@cchudant cchudant changed the title fix: error syncing closed blocks trough pendings fix: error syncing closed blocks through pendings Sep 9, 2024
@antiyro antiyro changed the title fix: error syncing closed blocks through pendings fix: adding the --starting-from arg back by ignoring ordered state Sep 10, 2024
Copy link
Member

@cchudant cchudant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🥳🥳🥳

Copy link

github-actions bot commented Sep 10, 2024

Coverage report

The coverage rate is 74.54165699698306%

100% of new lines are covered.

@antiyro antiyro merged commit f31bf57 into main Sep 11, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full node Full Node only related issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants