-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: class import #235
feat: class import #235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. Please check the below comments. It might also be a good idea to have someone like @cchudant check out this PR if you feel like you need a deeper look at the underlying logic of this part of the code, since I feel a bit rusty in this regard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally, class hashes!! 🥳
} | ||
} | ||
|
||
// use anyhow::{Context, Error, Ok, Result}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we remove that code?
also i think we should move toward tdelabro's hash chain struct, it's pretty cool
Coverage reportThe coverage rate is
Diff Coverage details (click to unfold)crates/client/rpc/src/test_utils.rs
crates/primitives/transactions/src/compute_hash.rs
crates/primitives/class/src/class_hash.rs
crates/primitives/class/src/class_update.rs
crates/client/block_import/src/pre_validate.rs
crates/primitives/state_update/src/lib.rs
crates/client/rpc/src/versions/v0_7_1/methods/read/get_class_at.rs
crates/primitives/block/src/lib.rs
crates/client/rpc/src/providers/mempool.rs
crates/primitives/class/src/into_starknet_core.rs
crates/client/rpc/src/versions/v0_7_1/methods/trace/simulate_transactions.rs
crates/primitives/transactions/src/broadcasted_to_blockifier.rs
crates/client/rpc/src/utils/transaction.rs
crates/client/db/src/storage_updates.rs
crates/primitives/chain_config/src/chain_config.rs
crates/primitives/class/src/compile.rs
crates/client/sync/src/fetch/fetchers.rs
crates/client/rpc/src/versions/v0_7_1/methods/read/get_class.rs
crates/primitives/class/src/lib.rs
crates/client/rpc/src/versions/v0_7_1/methods/read/estimate_fee.rs
crates/primitives/chain_config/src/starknet_version.rs
crates/client/db/src/class_db.rs
crates/client/exec/src/blockifier_state_adapter.rs
crates/client/block_import/src/types.rs
crates/primitives/transactions/src/from_broadcasted_transaction.rs
crates/primitives/block/src/header.rs
|
30c7fc9
to
d9d496d
Compare
Pull Request type
What is the current behavior?
Resolves: #233
What is the new behavior?
Does this introduce a breaking change?
Other information