Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix fault tolerance #161

Merged
merged 7 commits into from
Jun 14, 2024
Merged

Conversation

cchudant
Copy link
Member

@cchudant cchudant commented Jun 14, 2024

Pull Request type

  • Bugfix

What is the current behavior?

DB can get corrupted

What is the new behavior?

the mix of these:

  • disable wal
  • enable atomic flush
  • disable auto flush (apprently you can't really disable it completely, or at least I havent found how -- once the write buffer is filled rocksdb has to flush the memtables. hopefully the write is big enough for the later blocks)
  • flush at the end of a block if 5 sec has passed since last flush

enable us to be fault tolerant.

We can't just use transactions as they are not multithreaded and we really need parallelism for perf

Does this introduce a breaking change?

I don't think so

Other information

Added a little bit of cleanup

@cchudant cchudant marked this pull request as ready for review June 14, 2024 15:52
@cchudant cchudant changed the title fix: trying to fix fault tolerance fix: fix fault tolerance Jun 14, 2024
@antiyro antiyro merged commit 68122aa into madara-alliance:main Jun 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants